prs
Damus PRs

http://damus.io/code

damus iOS github pull request

Public Key

npub1ahckk8wkr64n2w5r4arsesf42upfhlmgy76vhxmlex7mvv4zhrnqry7v97

NIP-05 Address

prs@damus.io

Profile Code

nprofile1qqswmuttrhtpa2e482p673cvcy64wq5mla5z0dxtndlun0dkx23t3escwa50d

Author Public Key

npub1ahckk8wkr64n2w5r4arsesf42upfhlmgy76vhxmlex7mvv4zhrnqry7v97

Show more details

Last Notes

2024-01-17 03:58:07

Move mute thread further away from bookmark in note ellipsis menu (#1886)
Moved mute thread further away from bookmark in note ellipsis menu.
I am terrible coder. Not sure if this was this easy, or I missed more complexity.
If I didn't mess it up, this should close https://github.com/damus-io/damus/issues/1878
mutethread, 1 commits
https://github.com/damus-io/damus/pull/1886

2024-01-05 03:25:08

docs: fix typos (#1856)
null
master, 1 commits
https://github.com/damus-io/damus/pull/1856

2023-12-20 14:30:24

Fix Issue #1820 Hashtags including U+5009 to U+500D are not correctly parsed (#1830)
If the hashtag contains the kanji "double", it cannot be parsed correctly.
![IMG_3691](https://github.com/damus-io/damus/assets/1298867/f34972a0-6e90-4b32-92d9-0634a534b130)
Fix it.
![Simulator Screenshot - iPhone 15 Pro - 2023-12-20 at 23 26 46](https://github.com/damus-io/damus/assets/1298867/f645ac05-ba8c-483d-8e21-62476a96645b)
fix/issue/1820, 1 commits
https://github.com/damus-io/damus/pull/1830

2023-12-09 05:03:50

refactor: add customizable properties to neutral button style (#1805)
This PR refactors the NeutralButtonStyle to take in customizable properties for different button layouts instead of creating a struct for each situation that may arise, for example a small capsule button which I needed. Also added shape representations using NeutralButtonShape for ease of use.
![neutral buttons](https://github.com/damus-io/damus/assets/14004132/188d8bcd-2fa5-49bc-bd3c-1ccea5c39c02)
dynamic-neutral-button, 1 commits
https://github.com/damus-io/damus/pull/1805

2023-12-07 23:14:49

Translations (#1803)
null
translations, 7 commits
https://github.com/damus-io/damus/pull/1803

2023-12-02 18:59:43

ui: allow users to collapse suggested hashtag view (#1789)
Changelog-Added: Button to collapse suggested hashtag view
#note1svs…0803
collapse-hashtags, 1 commits
https://github.com/damus-io/damus/pull/1789

2023-12-02 05:27:51

ux: minor improvements to qrcode scanning in images (#1787)
Changelog-Fixed: Make check for lnurl case insensitive
Changelog-Added: Check for lnbc and allow users to select to open in wallet or copy
#note1053…pjf8
qr-scan-improvements, 1 commits
https://github.com/damus-io/damus/pull/1787

2023-11-30 23:13:16

Publish kind 10_002 (#1783)
This PR adds publishing for kind 10_002 (NIP-65), Apologies if i done something stupid, i'm not an iOS developer.
master, 1 commits
https://github.com/damus-io/damus/pull/1783

2023-11-29 19:11:34

packages: pin Vault to exact 1.0.0 (#1781)
null
1701284639/f76563b3/9a4d9382-pin-vault-depend-exact, 1 commits
https://github.com/damus-io/damus/pull/1781

2023-11-26 06:24:46

update testdata URL path method (#1767)
URL.absoluteString returns "files:///" prefix path, which causes previews error always.
URL.path would be the right method.
master, 1 commits
https://github.com/damus-io/damus/pull/1767

2023-11-22 02:08:27

ux: only handle one qr code in an image and add copy functionality (#1758)
This PR adds copy functionality when scanning a qr code in an image and fixes the issue where there are multiple qr codes in an image by only using the last value found.
#note1x59…fl49
minor-qr-improvements, 1 commits
https://github.com/damus-io/damus/pull/1758

2023-11-22 00:36:44

Media Preview Setting (#1757)
This PR adds the Media preview setting in order to allow users to toggle previewing media such as links, images, videos, gif, etc. or to only preview when tapped.
#note1vm2…r0cy
media-previews-setting, 1 commits
https://github.com/damus-io/damus/pull/1757

2023-11-21 02:06:15

refactor: rename show image references to blur images (#1745)
This PR renames the "Always show images" setting to "Blur images"
blur-images-refactor, 1 commits
https://github.com/damus-io/damus/pull/1745

2023-10-07 04:14:26

Hide recommended relay view (#1587)
This PR allows users to hide the recommended relay view. Also allows them to show the view when they click edit. See video https://damus.io/note1nefs6qn35cenk6ptzy06htyv2huqcjqphcklpkfnkvhdfvy0wtpq6q9fem
hide_recommended, 1 commits
https://github.com/damus-io/damus/pull/1587

2023-09-20 00:21:03

Scan QR code from static image (#1550)
This PR allows users to open the link in a QR Code if it exists. Detects if there is a qr code and extracts that info, if it is an lnurl it'll append the lightning prefix so it can be opened by a lightning wallet. If it is a regular link it'll open a dialog to ask the user if they want to open the link, with the link displayed. If there is no link it show a dialog that says no qr code found.
See these notes for video examples:
https://damus.io/note1mpc6y8ft80wpavmedsy7h08s7n2l95flm0d3tlqd6hfdd27ta38s4rusrj
https://damus.io/note1dw9y7lc09f3694avg2z2a82kc68yh479vkkur336g78w9svh3tfsp0yy5g
scan-image-qr, 1 commits
https://github.com/damus-io/damus/pull/1550

2023-09-05 15:47:35

[#1530] Create new controls UI for video playback (#1537)
Addresses #1530
Create a new controls UI layer for the DamusVideoPlayer, providing play/pause, volume control, content scale, playback rate controls, as well as a seek/timecode bar.
<img width="594" alt="Screenshot 2023-09-05 at 11 42 46" src="https://github.com/damus-io/damus/assets/1031501/de89196e-0951-4a59-8430-99a8cd166e60">
<img width="586" alt="Screenshot 2023-09-05 at 11 42 55" src="https://github.com/damus-io/damus/assets/1031501/4a947870-640d-4c7e-89f7-1eab30326aa3">
Current features:
- Scrub on the horizontal seek bar to change the playback time
- Play/Pause button
- Mute/Unmute button and volume vertical slider
- Select playback rate from 0.5x up to 2.0x
- Tap video to hide/show controls
- Player has option to hide controls on startup
- Player's video tap behavior can be customized
Fixes:
- The VideoPlayer has been reworked from frame-by-frame updating to an event-driven model, significantly improving performance and understandability.
Known Issues:
- This still suffers from [#1386] as that is a navigation/data model architecture issue, not specific to the video player.
Note:
- This feature DOES NOT INCLUDE A FIX FOR #1386 ! That fix will be provided in a future PR.
Bounty: 100k satoshis(BTC) -> 0.001 BTC
Payout Address: `bc1q5sxugecyhq5stxn4d79p4908hdr7ljcn35uyk7`
<img width="341" alt="btc001" src="https://github.com/damus-io/damus/assets/1031501/54552b4f-ad4e-4842-b1a2-2ac44bf47ad7">
issue/1530-video-controls, 2 commits
https://github.com/damus-io/damus/pull/1537

2023-08-28 15:02:49

Profiles in nostrdb (#1520)
This adds profiles to nostrdb and replaces our in-memory and ProfileDatabase cache with it
- Remove in-memory Profiles caches, nostrdb is as fast as an in-memory cache
- Remove ProfileDatabase and just use nostrdb directly
## TODO
- [ ] cache lnurl properly
- [ ] add database versions for migrations
nostrdb-profiles, 5 commits
https://github.com/damus-io/damus/pull/1520

2023-08-22 04:02:21

Simplify and inline Report event logic. (#1498)
Simplify and inline Report event logic. Move the tag enum unpacking into a fileprivate extension, unpack the event-creation functions that used the `Report` model as a throw-away intermediate step to creating a NostrEvent object.
refactor/report, 1 commits
https://github.com/damus-io/damus/pull/1498

2023-08-21 21:28:14

Move the Block helper type to its own file (#1496)
Move the Block helper type to its own file, collapse the various standalone functions for parsing block data, and refactor consumers to initialize a Block with given data and access its members as needed. This is a more "idiomatic" approach to these C-backed data structures, and moves a number of these functions, extensions, and types into `fileprivate` scope, removing them from the global symbols and generally cleaning up their interface and usage. I plan to continue these "cleanup and refactor" changes as I learn more about the repository.
refactor/block-initializer, 1 commits
https://github.com/damus-io/damus/pull/1496

2023-08-21 05:51:57

Avoid notification for zap from mute profile (#1494)
Fixing issue #1382
Checks if the event pkey is in the mute list
Could not test the code, but it is a simple straightforward solution
mute-notify-zap, 1 commits
https://github.com/damus-io/damus/pull/1494

2023-08-19 17:23:24

Create VersionTest.swift (#1491)
VersionTest.swift for #1490
master-3, 1 commits
https://github.com/damus-io/damus/pull/1491

2023-08-19 03:00:31

Update damus.c (#1487)
Possible fix for #1375
master-1, 1 commits
https://github.com/damus-io/damus/pull/1487

2023-08-14 19:48:28

Adding zap icon to Eurothon hashtag (#1477)
Adding the Zap ⚡️ icon to the Eurothon hashtag.
I created a new property for Eurothon.
I'm using the same svg icon file, just like the Zapathon hashtag.
I couldn't test it because I don't have a macOS environment.
Issue: #1474
eurothon-zap, 1 commits
https://github.com/damus-io/damus/pull/1477

2023-08-13 18:07:06

Fixing counting -1 (#1473)
Fix for issue #1467
The 'others' count is higher than pubkeys count
Note json :
`{
"pubkey": "97c70a44366a6535c145b333f973ea86dfdc2d7a99da618c40c64705ad98e322",
"content": "No, just so other people can hear and profit, that's the point of the podcast. But I see you're PNW too, coffee also works if we end up in the same vicinity!",
"id": "2c271f78da9522a342f6178667e4dd30423cab65a559f1fd683071d130fc3477",
"created_at": 1691611954,
"sig": "de62016ad6260180f9f99b83773066c60db63790560e3bd6239995e26526d647a2776469f6de0855bd9deab8d2a42c1fcddd275b07f7b5924bb0d4a922f486e3",
"kind": 1,
"tags": [
[
"p",
"61066504617ee79387021e18c89fb79d1ddbc3e7bff19cf2298f40466f8715e9",
"wss:\\/\\/anon.computer",
"atyh"
],
[
"e",
"b7f986c892a0f128c131ab90996fcb94fac2c80869cb88a5d021e0b2f3609045",
"wss:\\/\\/offchain.pub",
"root"
],
[
"e",
"ad8d909a66d848a6101d7482245f484c86e3d6597fcec19921e1cc0f5b6e94fb"
],
[
"e",
"18ebd3e8f86bf3f318ed0a71e3853855bde59f3be433e37a958b33be8273f8e6",
"wss:\\/\\/offchain.pub",
"reply"
],
[
"client",
"coracle"
]
]
}`
replay-counting-fix, 1 commits
https://github.com/damus-io/damus/pull/1473

2023-08-12 12:02:10

Add nip 98 support for nostr.build (#1471)
This change implements support for NIP-98 and uses it for uploads to nostr.build. It is also changing the nostr.build API end-point to V2. Implements #823
add-nip-98-support-nostr-build, 7 commits
https://github.com/damus-io/damus/pull/1471

2023-07-16 12:55:48

Include .m3u8 for video playback to enable streaming (#1372)
This trivial change should enable HLS streaming and adaptable bit rate playback for video playback.
add-m3u8-support, 1 commits
https://github.com/damus-io/damus/pull/1372

2023-07-15 19:08:40

Fix for #1206 Hide nsec when logging in & add hide/show toggle (#1371)
Fix for Hide nsec when logging in & add hide/show toggle [security][feature request]#1206
master, 1 commits
https://github.com/damus-io/damus/pull/1371

2023-07-10 20:33:53

Fix for: Hashtags in foreign languages #949 (#1360)
Changes to boundary detection of hashtags and fix for urlencoding of second colon where hashtag contains foreign character set.
master, 3 commits
https://github.com/damus-io/damus/pull/1360

2023-06-26 00:28:27

Disable post button when media upload in progress (#1324)
Fixes https://github.com/damus-io/damus/issues/1317
tyiu/disable-posting-during-upload, 1 commits
https://github.com/damus-io/damus/pull/1324

2023-06-08 23:54:08

[UX] Fix Issue 1238: Videos sounds can play over each other (#1266)
Fix issue #1238
This is a Draft - current solution seems fairly robust - scroll away & video stops; scroll back & it starts over -
...but still investigating potentially more robust solutions i.e. whether it could be more responsive / sensitive to scrolling away even at higher scroll speed (as in below demo)
Demo video of current fix in this post: [~1 min. / 50MB]
UX-DamusVideoPlayer--Fix-Issue-1238--Videos-sounds-can-play-over-each-other, 1 commits
https://github.com/damus-io/damus/pull/1266

2023-06-08 12:09:51

add relay logging (#1263)
This PR adds relay logging to the RelayDetailView.
Features:
* list of events, most recent at the top
* shows changes to RelayConnection's state
* shows changes to network state
* RelayDetailView updates live as lines are added to the log
* logs persisted to disk for later investigation
* line limit prevents unbounded file growth
Here's how it looks when resuming after having the app in the background for a while and the relays need to reconnect:
![relay-log](https://github.com/damus-io/damus/assets/445882/fd788aae-ed44-49c5-9dd1-4e6c7398456e)
relays, 5 commits
https://github.com/damus-io/damus/pull/1263

2023-06-04 17:31:28

NostrScript (#1246)
NostrScript is a WebAssembly implementation that interacts with Damus. It enables dynamic scripting that can be used to power custom list views, enabling pluggable algorithms.
The web has JavaScript, Damus has NostrScript. NostrScripts can be written in any language that compiles to WASM.
This commit adds a WASM interpreter I've written as a mostly-single C file for portability and embeddability. In the future we could JIT-compile these for optimal performance if NostrScripts get large and complicated. For now an interpreter is simple enough for algorithm list view plugins.
Changelog-Added: Add initial NostrScript implementation
nostrscript, 1 commits
https://github.com/damus-io/damus/pull/1246

2023-05-27 02:14:05

Setup, Login, Create Account redesign (#1187)
Implementing @robagreda designs from here: [Figma](https://www.figma.com/file/ORaT1T0Ywfbm0sIjwy5Rgq/Damus-iOS?type=design&node-id=1069-28898&t=kGXqjuQOm7hSXbzW-0)
**Account Creation flow**:
----------**iPhone 14 Pro Max iOS 16**-------------------**iPhone 12 Mini iOS 15.5**----------
![iPhone 14 Pro Max](https://github.com/damus-io/damus/assets/14004132/593ceafc-561d-4cc8-9a5d-39eb4cd4d826) ![iPhone 12 mini](https://github.com/damus-io/damus/assets/14004132/25f3e1db-e4b5-4169-b9fc-29fb22dc717a)
robs-onboarding-redesign, 52 commits
https://github.com/damus-io/damus/pull/1187

2023-05-16 17:18:55

Giphy integration (#1142)
Through the integration of the Giphy SDK, users gain a transformative ability to enrich their posts and replies with captivating GIF media files. Moreover, the integration of Giphy's extensive library of GIFs offers an endless array of visual content, allowing users to select the perfect expression to accompany their words. Whether it's a fleeting moment of joy, a burst of creativity, or a heartfelt sentiment, the availability of GIFs enhances the power of self-expression, making each interaction more personalized and memorable.
Below is Youtube video link for showing Giphy work-flow in Damus
https://www.youtube.com/watch?v=QPklQhs6aBw
giphy-integration, 2 commits
https://github.com/damus-io/damus/pull/1142

2023-05-14 18:13:53

Fix nostr URL scheme to open properly even if there's already a different view open (#1130)
Changelog-Fixed: Fix nostr URL scheme to open properly even if there's already a different view open
tyiu/navigation-bug, 1 commits
https://github.com/damus-io/damus/pull/1130

2023-05-12 03:28:40

Migrate away from sticky deprecated non-pubkey-scoped settings (#1124)
Changelog-Fixed: Migrate away from sticky deprecated non-pubkey-scoped settings
This fixes a bug where older users of Damus who created another account could have OnlyZaps enabled even though the default is false.
tyiu/unstick-settings, 1 commits
https://github.com/damus-io/damus/pull/1124

2023-05-10 04:50:03

fix crash related to preloading events (#1115)
This PR fixes the top crash in build 1.4.3(24):
<img width="376" alt="damus_—_Profiles_swift" src="https://github.com/damus-io/damus/assets/445882/1cf51c52-920d-43a7-a832-0776790557d8">
The crash is caused by a data contention for the `profiles` dictionary in the `Profiles` class. Many views and view models access this dictionary from the main thread by calling `Profiles.lookup(id:)`. `Profiles.add(id:profile:)` is currently called only from the main thread. However, the stack trace in the crash report indicates that it happens when `Profiles.lookup(id:)` is called from a non-main thread during event preloading. When a profile is added on the main thread and a profile lookup occurs on a non-main thread at the same time, we have a data contention and the app crashes.
To resolve this, I added a concurrent `DispatchQueue` to synchronize access to the `profiles` dictionary. Concurrent reads can happen safely from both main and non-main threads, but writes will happen asynchronously and use the `barrier` flag to enforce exclusive access.
An alternative fix would be to make the `Profiles` class an `actor` instead of a `class`, which automatically synchronizes access to all of its members. I chose not to pursue this solution because it would also make `Profiles.lookup(id:)` `async`, which would change all the call sites.
profiles-crash, 1 commits
https://github.com/damus-io/damus/pull/1115

2023-05-10 02:43:30

Add translate.nostr.wine to available translation services (#1113)
Added translate.nostr.wine to the translation service options in Settings. Thank you for making it very easy. Please let us know if we missed anything.
Powered by DeepL and backed up by Google Cloud Translation API if the language is not supported.
master, 1 commits
https://github.com/damus-io/damus/pull/1113

2023-05-09 23:15:49

Fix Issue #1038 - "User tag autocomplete message area blocks text input" (#1111)
Fix Issue #1038
Fix:
-Cursor in a post/reply now remains visible (regardless of initial location) even when the search/autocomplete view `UserSearch` is present
Change:
-Conditionally set the `.isScrollEnabled` of `TextViewWrapper`(ie, default =true; and =false only when `UserSearch` is present)
bugfix-UI-1038--User-tag-autocomplete-message-area-blocks-text-input, 2 commits
https://github.com/damus-io/damus/pull/1111

2023-05-07 16:01:53

Translations (#1103)
null
translations, 12 commits
https://github.com/damus-io/damus/pull/1103

2023-05-07 03:20:18

in-text-mentioning (#1102)
By making this adjustment, we will be able to mention individuals by repositioning the cursor within the previously composed content of a post. Currently, we are only able to mention individuals at the end of a post and not during the editing process.
Demo video of in-text-mentioning:
https://nostr.build/av/41fa86e2c858ed2fefaeef56edaaf4cd001543c86e57fe76a9b97fdba3a2b1e0.mov
in-text-mentioning, 1 commits
https://github.com/damus-io/damus/pull/1102

2023-05-06 03:11:42

fix: npub search fails on the first try (#1100)
This PR fixes the issue where npub search fails on the first try.
What was happening:
`SearchEventView` calls `find_event(state:evid:search_type:find_from:callback:)` to search for the entered npub. The search actually succeeded, but the call site was ignoring the returned event and never caching the profile. The reason it works the second time is because the `RelayPool` eventually got around to caching the profile. This is also why the other PR related to this issue works by adding a short delay.
How it's fixed:
Now `SearchingEventView` will call `process_metadata_event(events:our_pubkey:profiles:ev:)`, and upon completion, will update the view state with the successful result.
fix-npub-search, 1 commits
https://github.com/damus-io/damus/pull/1100

2023-05-05 17:42:28

Hello Nostr (#1095)
Webhook works!
1 commits
https://github.com/damus-io/damus/pull/1095