npub19v7lz5n67uygmsr24rsw9arejnfxhwa3npkk00qpe8tx5ujdtpgs95al4a (npub19v7…al4a) I’m pretty sure the try/catch block should handle when errors are thrown, then the promise is set to null *after* the try/catch block, so it should always be set to null for success and failure cases.
In theory a function in the catch block could throw an error, but I inspected them and don’t think that’s a real possibility.
Thanks for the code review though :)
Mitch Downey :pci: /
npub1yf…w6g6v
2023-11-04 16:55:48
in reply to nevent1q…gyr9
Author Public Key
npub1yfr5d05qj3qzz84kntze3c8accyz0unwczgm0fxuypuqdnenkwuqew6g6vPublished at
2023-11-04 16:55:48Event JSON
{
"id": "3d52c2a37c119e993ac7152d36eec3af8af88831c68f2ed076e48cdc1c352fdf",
"pubkey": "224746be809440211eb69ac598e0fdc60827f26ec091b7a4dc207806cf33b3b8",
"created_at": 1699116948,
"kind": 1,
"tags": [
[
"p",
"2b3df1527af7088dc06aa8e0e2f47994d26bbbb1986d67bc01c9d66a724d5851",
"wss://relay.mostr.pub"
],
[
"p",
"b7fe4910768fb0b39d42bee0b6b2fa60a51a6906bffd0565a144b0b8a6e460b9",
"wss://relay.mostr.pub"
],
[
"e",
"b2b69bad21f81f58839e52ceac9605aca4a66f0d3793f72bed742d294b882671",
"wss://relay.mostr.pub",
"reply"
],
[
"proxy",
"https://podcastindex.social/users/mitch/statuses/111353328352615977",
"activitypub"
]
],
"content": "nostr:npub19v7lz5n67uygmsr24rsw9arejnfxhwa3npkk00qpe8tx5ujdtpgs95al4a I’m pretty sure the try/catch block should handle when errors are thrown, then the promise is set to null *after* the try/catch block, so it should always be set to null for success and failure cases.\n\nIn theory a function in the catch block could throw an error, but I inspected them and don’t think that’s a real possibility.\n\nThanks for the code review though :)",
"sig": "dcccd296b39fa3a1a70c8dd40a1039a8ad6ea3526dae87a5f9637de7db97dae0b56d34396284a9e209e99df806acae8c5e938d2fff01463941ba53d73ab6d7c3"
}