ben on Nostr: if you want to improve your oss contributions, I’d encourage you to take a look at ...
if you want to improve your oss contributions, I’d encourage you to take a look at Will’s pr below and note:
- multiple, small commits. this allows reviewers to step through the pr. it tells a story.
- commit messages include a concise subject line and a more descriptive body.
- commit formats match the existing conventions in the codebase
I will take a look at this! https://crates.io/crates/nostrdb isn’t quite ready for this from what I can tell.
btw in the meantime I did this PR which I need for a project I’m working on:
https://github.com/rust-nostr/nostr/pull/215
Published at
2023-12-16 20:18:32Event JSON
{
"id": "8085f7ac4845ff555144f023744d95c692715759bd88c17a6b0c33fa28d4c858",
"pubkey": "7bdef7bdebb8721f77927d0e77c66059360fa62371fdf15f3add93923a613229",
"created_at": 1702757912,
"kind": 1,
"tags": [
[
"q",
"61ba236d8a35dc006b574a223f0a86a4955b81ff48741c98f423a1caed692932"
],
[
"p",
"32e1827635450ebb3c5a7d12c1f8e7b2b514439ac10a67eef3d9fd9c5c68e245"
],
[
"p",
"32e1827635450ebb3c5a7d12c1f8e7b2b514439ac10a67eef3d9fd9c5c68e245"
]
],
"content": "if you want to improve your oss contributions, I’d encourage you to take a look at Will’s pr below and note:\n\n- multiple, small commits. this allows reviewers to step through the pr. it tells a story.\n- commit messages include a concise subject line and a more descriptive body. \n- commit formats match the existing conventions in the codebase nostr:note1vxazxmv2xhwqq66hfg3r7z5x5j24hq0lfp6pex85ywsu4mtf9yeqpue890",
"sig": "c6edaee649e6bff1f82b84e84948596fe73b5bddca83148dd784539b34ec6164b61ede93c9927ea9d3b971eb8982b047b4bec24402a58ca53e3cf3c211e865d9"
}
