📅 Original date posted:2021-11-26
📝 Original message:This has also been posted on Bitcointalk forum: https://bitcointalk.org/index.php?topic=5373341.msg58539261#msg58539261 I have republished it here hoping someone more knowledgeable can post some insight about this.
----
It appears that the ZeroMQ topic I'm listening to, "rawtx", not only emits a raw transaction when it appears on the mempool, but once it's already confirmed too.
This messes with my software, causing it to add txids, addresses, etc. a second time inside arrays (this means that the same transaction is received twice in total).
Array de-duping is not a viable solution long-term (because the array will quickly grow to be big eventually and then this has to happen every time a new element is added), so I'm trying to nip the problem from the source by instructing Core to only publish unconfirmed bitcoin transactions.
According to https://bitcoin.stackexchange.com/questions/52848/is-it-possible-to-configure-the-bitcoin-daemon-to-only-broadcast-unconfirmed-tra , it is not possible to configure this from a configuration or command-line option. The source code must directly be edited. But since the codebase has changed greatly, the proposed solution no longer works.
----
So basically, I know that something inside src/zmq/zmqnotificationinterface.cpp needs to be patched, but I'm not sure which function, or how to do it. Because I only need unconfirmed transactions to be published on ZeroMQ rawtx and not confirmed ones, it's one of the following functions that I need to patch for my own build:
CZMQNotificationInterface::TransactionRemovedFromMempool
void CZMQNotificationInterface::BlockDisconnected
Both of these call NotifyTransaction() method which I assume fires a message on "rawtx" channel.
In the Stack Exchange question I linked above, Jonas Schnelli suggested adding an `if (!pblock)` check, but that was several years ago and the function he was referencing no longer exists.
But I still wonder if the pblock check is still applicable in the present day (i.e. if it's indicating a block the transaction is inside).
- Ali Sherief
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20211126/f91da026/attachment.html>;
Ali Sherief [ARCHIVE] /
npub1xq…q2u5f
2023-06-07 23:00:41
in reply to nevent1q…udv6
Author Public Key
npub1xq96jnxfzrdq4zgre20yqjrjsd29vcw8ymypl4v59cg6q6p66cts8q2u5fPublished at
2023-06-07 23:00:41Event JSON
{
"id": "2b2aaae28c2a5d9afc75ec6bccaeb78dd6208067a1af76c803cff662f85feb3d",
"pubkey": "300ba94cc910da0a8903ca9e40487283545661c726c81fd5942e11a0683ad617",
"created_at": 1686178841,
"kind": 1,
"tags": [
[
"e",
"73bd2fcc65905c590b1efffa4177a6a9c04f9ffb7c4952c1416d51008eae18e7",
"",
"reply"
],
[
"p",
"a23dbf6c6cc83e14cc3df4e56cc71845f611908084cfe620e83e40c06ccdd3d0"
]
],
"content": "📅 Original date posted:2021-11-26\n📝 Original message:This has also been posted on Bitcointalk forum: https://bitcointalk.org/index.php?topic=5373341.msg58539261#msg58539261 I have republished it here hoping someone more knowledgeable can post some insight about this.\n----\nIt appears that the ZeroMQ topic I'm listening to, \"rawtx\", not only emits a raw transaction when it appears on the mempool, but once it's already confirmed too.\n\nThis messes with my software, causing it to add txids, addresses, etc. a second time inside arrays (this means that the same transaction is received twice in total).\n\nArray de-duping is not a viable solution long-term (because the array will quickly grow to be big eventually and then this has to happen every time a new element is added), so I'm trying to nip the problem from the source by instructing Core to only publish unconfirmed bitcoin transactions.\n\nAccording to https://bitcoin.stackexchange.com/questions/52848/is-it-possible-to-configure-the-bitcoin-daemon-to-only-broadcast-unconfirmed-tra , it is not possible to configure this from a configuration or command-line option. The source code must directly be edited. But since the codebase has changed greatly, the proposed solution no longer works.\n\n----\n\nSo basically, I know that something inside src/zmq/zmqnotificationinterface.cpp needs to be patched, but I'm not sure which function, or how to do it. Because I only need unconfirmed transactions to be published on ZeroMQ rawtx and not confirmed ones, it's one of the following functions that I need to patch for my own build:\n\nCZMQNotificationInterface::TransactionRemovedFromMempool\nvoid CZMQNotificationInterface::BlockDisconnected\n\nBoth of these call NotifyTransaction() method which I assume fires a message on \"rawtx\" channel.\n\nIn the Stack Exchange question I linked above, Jonas Schnelli suggested adding an `if (!pblock)` check, but that was several years ago and the function he was referencing no longer exists.\n\nBut I still wonder if the pblock check is still applicable in the present day (i.e. if it's indicating a block the transaction is inside).\n\n- Ali Sherief\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20211126/f91da026/attachment.html\u003e",
"sig": "6e51929b910181a1f1dc17a38a8413b6b90d10aa2db79061cce2c5d9aa05b1ac724d9618904c6986e72b6e1d0a12725c1e822994d579130746060e30a113498d"
}