This morning, focusing on LeakCanary for a bit:
I think I've noticed a bug in how retained size increase for growing objects is computed in LeakCanary, because I noticed it seems to be 0 sometimes, included in cases where it's a very simple fake heap dump where it shouldn't be 0.
So I look at the tests for retained size.
Oh. No such tests 😬. Shame on me! While I do have tests for the dominator computation code, I don't have integration tests for how that's used in the heap growth code.
P-Y /
npub19w…7g5sa
2024-05-16 16:16:23
Author Public Key
npub19wwxc29uufy6rmegf9aza3hkcqdu00s8yyfyhr88mglptysgp3tsz7g5saPublished at
2024-05-16 16:16:23Event JSON
{
"id": "6ff002a4c3bdd73886138ac97e12663e13ce6583807d030fdff8946857a452f1",
"pubkey": "2b9c6c28bce249a1ef28497a2ec6f6c01bc7be0721124b8ce7da3e1592080c57",
"created_at": 1715876183,
"kind": 1,
"tags": [
[
"proxy",
"https://androiddev.social/users/py/statuses/112451661553776747",
"activitypub"
]
],
"content": "This morning, focusing on LeakCanary for a bit:\n\nI think I've noticed a bug in how retained size increase for growing objects is computed in LeakCanary, because I noticed it seems to be 0 sometimes, included in cases where it's a very simple fake heap dump where it shouldn't be 0.\n\nSo I look at the tests for retained size.\n\nOh. No such tests 😬. Shame on me! While I do have tests for the dominator computation code, I don't have integration tests for how that's used in the heap growth code.",
"sig": "ab2ad7db82b105cac4210b1ca237a4feeed834cef5820f31a9a43b03cdf5253cc510461e53d5d819b52ac743ae6eb4dd7a7897ee68298d03d59c4d30ab5d212e"
}