📅 Original date posted:2017-03-13
📝 Original message:>time >= 1506816000 && time <= 1510704000 && !IsWitnessEnabled()
This has a different start time from the first post.
>if (pindex->GetMedianTimePast() >= 1538352000 &&
pindex->GetMedianTimePast() <= 1510704000 ...
Thanks,
--Nick
On Mon, Mar 13, 2017 at 4:36 AM, shaolinfry via bitcoin-dev <
bitcoin-dev at lists.linuxfoundation.org> wrote:
> From: luke at dashjr.org
> On Sunday, March 12, 2017 3:50:27 PM shaolinfry via bitcoin-dev wrote:
> > // mandatory segwit activation between Oct 1st 2017 and Nov 15th 2017
> > inclusive if (pindex->GetMedianTimePast() >= 1538352000 &&
> > pindex->GetMedianTimePast() <= 1510704000 &&
> > !IsWitnessEnabled(pindex->pprev, chainparams.GetConsensus())) {
> > if (!((pindex->nVersion & VERSIONBITS_TOP_MASK) ==
> > VERSIONBITS_TOP_BITS) && (pindex->nVersion & VersionBitsMask(params,
> > Consensus::DEPLOYMENT_SEGWIT)) != 0) {
> > return state.DoS(2, error("ConnectBlock(): relayed block must
> > signal for segwit, please upgrade"), REJECT_INVALID,
> > "bad-no-segwit");
> > }
> > }
>
> I don't think this is actually BIP 9 compatible. Once activated, the bit
> loses
> its meaning and should not be set. So you need to check that it hasn't
> locked-
> in already...
>
>
> I believe that is handled.
>
> time >= 1506816000 && time <= 1510704000 && !IsWitnessEnabled()
>
> Signalling is only required from October 1st until the BIP9 timeout, or,
> until segwit is activated. The bit becomes free after activation/timeout as
> per BIP9. Also, the default behaviour of BIP9 in Bitcoin Core is to signal
> through the LOCKED_IN period - it would be trivial to add a condition to
> not require mandatory signalling during LOCKED_IN but since miners signal
> by default during this period, I figured I would leave it.
>
> I thought about 5% tolerance. but I don't think it makes sense since
> miners will already have plenty of warning this is coming up and the intent
> of the mandatory signalling period is quite clear. It also seems a bit
> weird to say "it's mandatory but not for 5%". If miners are required to
> signal, they need to signal. It also adds unnecessary complexity to an
> otherwise simple patch.
>
> That said, I have no strong feelings either way on both counts, but I
> chose to present the simplest option first.
>
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20170313/1488d886/attachment.html>;
Nick ODell [ARCHIVE] /
npub192…qwur0
2023-06-07 17:57:14
in reply to nevent1q…9srl
Author Public Key
npub192dh6dprqsvsrdeche436s9xunwnlyzpu7jl5j3d83nz62tgznrsnqwur0Published at
2023-06-07 17:57:14Event JSON
{
"id": "64e2126e3cf28fd67e0495a206670df18d613b061ec410a78aba12633b749424",
"pubkey": "2a9b7d3423041901b738be6b1d40a6e4dd3f9041e7a5fa4a2d3c662d296814c7",
"created_at": 1686160634,
"kind": 1,
"tags": [
[
"e",
"c85e331219b41163c53d11241cf7a40c8747f1688f2c56a907ca61b00451e77b",
"",
"root"
],
[
"e",
"6780534242e211c08a870265dbde5f0424916856399dffa2127f394185e25908",
"",
"reply"
],
[
"p",
"512c64351a85e9323c34af13b4dfcf320615bacb09132ae6da9ce671b7942825"
]
],
"content": "📅 Original date posted:2017-03-13\n📝 Original message:\u003etime \u003e= 1506816000 \u0026\u0026 time \u003c= 1510704000 \u0026\u0026 !IsWitnessEnabled()\nThis has a different start time from the first post.\n\u003eif (pindex-\u003eGetMedianTimePast() \u003e= 1538352000 \u0026\u0026\npindex-\u003eGetMedianTimePast() \u003c= 1510704000 ...\n\nThanks,\n--Nick\n\nOn Mon, Mar 13, 2017 at 4:36 AM, shaolinfry via bitcoin-dev \u003c\nbitcoin-dev at lists.linuxfoundation.org\u003e wrote:\n\n\u003e From: luke at dashjr.org\n\u003e On Sunday, March 12, 2017 3:50:27 PM shaolinfry via bitcoin-dev wrote:\n\u003e \u003e // mandatory segwit activation between Oct 1st 2017 and Nov 15th 2017\n\u003e \u003e inclusive if (pindex-\u003eGetMedianTimePast() \u003e= 1538352000 \u0026\u0026\n\u003e \u003e pindex-\u003eGetMedianTimePast() \u003c= 1510704000 \u0026\u0026\n\u003e \u003e !IsWitnessEnabled(pindex-\u003epprev, chainparams.GetConsensus())) {\n\u003e \u003e if (!((pindex-\u003enVersion \u0026 VERSIONBITS_TOP_MASK) ==\n\u003e \u003e VERSIONBITS_TOP_BITS) \u0026\u0026 (pindex-\u003enVersion \u0026 VersionBitsMask(params,\n\u003e \u003e Consensus::DEPLOYMENT_SEGWIT)) != 0) {\n\u003e \u003e return state.DoS(2, error(\"ConnectBlock(): relayed block must\n\u003e \u003e signal for segwit, please upgrade\"), REJECT_INVALID,\n\u003e \u003e \"bad-no-segwit\");\n\u003e \u003e }\n\u003e \u003e }\n\u003e\n\u003e I don't think this is actually BIP 9 compatible. Once activated, the bit\n\u003e loses\n\u003e its meaning and should not be set. So you need to check that it hasn't\n\u003e locked-\n\u003e in already...\n\u003e\n\u003e\n\u003e I believe that is handled.\n\u003e\n\u003e time \u003e= 1506816000 \u0026\u0026 time \u003c= 1510704000 \u0026\u0026 !IsWitnessEnabled()\n\u003e\n\u003e Signalling is only required from October 1st until the BIP9 timeout, or,\n\u003e until segwit is activated. The bit becomes free after activation/timeout as\n\u003e per BIP9. Also, the default behaviour of BIP9 in Bitcoin Core is to signal\n\u003e through the LOCKED_IN period - it would be trivial to add a condition to\n\u003e not require mandatory signalling during LOCKED_IN but since miners signal\n\u003e by default during this period, I figured I would leave it.\n\u003e\n\u003e I thought about 5% tolerance. but I don't think it makes sense since\n\u003e miners will already have plenty of warning this is coming up and the intent\n\u003e of the mandatory signalling period is quite clear. It also seems a bit\n\u003e weird to say \"it's mandatory but not for 5%\". If miners are required to\n\u003e signal, they need to signal. It also adds unnecessary complexity to an\n\u003e otherwise simple patch.\n\u003e\n\u003e That said, I have no strong feelings either way on both counts, but I\n\u003e chose to present the simplest option first.\n\u003e\n\u003e _______________________________________________\n\u003e bitcoin-dev mailing list\n\u003e bitcoin-dev at lists.linuxfoundation.org\n\u003e https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev\n\u003e\n\u003e\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20170313/1488d886/attachment.html\u003e",
"sig": "2c3ef80334a3a3551be81a75f3a49703605f11344fbe883d64f486ede07fd1c231da7776a29160e2781ec141d6d489137100cbabd5747ef0a81a19f31ae4c130"
}