📅 Original date posted:2019-03-13
📝 Original message:On 12/03/2019 23.14, Gregory Maxwell via bitcoin-dev wrote:
> On Tue, Mar 12, 2019 at 7:45 PM Andreas Schildbach via bitcoin-dev
> <bitcoin-dev at lists.linuxfoundation.org> wrote:
>> These two cases are understood and handled by current code. Generally
>> the idea is take reject messages serious, but don't overrate the lack
>> of. Luckily, network confirmations fill the gap. (Yes, a timeout is
>
> I'd like to better understand this, but it would be easier to just
> read the code than ask a bunch of questions. I tried looking for the
> handling of reject messages in Android Bitcoin Wallet and BitcoinJ
> and didn't really find and handling other than logging exceptions.
> Would you mind giving me a couple pointers to where in the code
> they're handled?
It's implemented in bitcoinj's TransactionBroadcast class. Received
reject messages are collected and -- if a certain consensus (currently:
half of connected peers) is reached -- a RejectedTransactionException is
raised.
The handling of that exception in Bitcoin Wallet is extremely
rudimentary. I think it still only shows the exception message. But
certainly I was hoping to improve on this soon.
Andreas Schildbach [ARCHIVE] /
npub1xg…adsv7
2023-06-07 18:16:37
in reply to nevent1q…tkry
Author Public Key
npub1xg2m84malu0cfm4444r0kysx4rgk27e75aj6sz6538kw8fcz627qeadsv7Published at
2023-06-07 18:16:37Event JSON
{
"id": "e9b0bf751ec9f96b35fc13df4a54ea4bdccefe7f2d7b39834ff1bb623ca04a58",
"pubkey": "3215b3d77dff1f84eeb5ad46fb1206a8d1657b3ea765a80b5489ece3a702d2bc",
"created_at": 1686161797,
"kind": 1,
"tags": [
[
"e",
"d23d84909ded4e86934b4199a32650fb490f51617593613544f6edda083d91e3",
"",
"root"
],
[
"e",
"72ddb6ccf88bdbb1c812842cf8b3030fcc134967f993837e252eea13de5edcc1",
"",
"reply"
],
[
"p",
"4aa6cf9aa5c8e98f401dac603c6a10207509b6a07317676e9d6615f3d7103d73"
]
],
"content": "📅 Original date posted:2019-03-13\n📝 Original message:On 12/03/2019 23.14, Gregory Maxwell via bitcoin-dev wrote:\n\u003e On Tue, Mar 12, 2019 at 7:45 PM Andreas Schildbach via bitcoin-dev\n\u003e \u003cbitcoin-dev at lists.linuxfoundation.org\u003e wrote:\n\u003e\u003e These two cases are understood and handled by current code. Generally\n\u003e\u003e the idea is take reject messages serious, but don't overrate the lack\n\u003e\u003e of. Luckily, network confirmations fill the gap. (Yes, a timeout is\n\u003e \n\u003e I'd like to better understand this, but it would be easier to just\n\u003e read the code than ask a bunch of questions. I tried looking for the\n\u003e handling of reject messages in Android Bitcoin Wallet and BitcoinJ\n\u003e and didn't really find and handling other than logging exceptions.\n\u003e Would you mind giving me a couple pointers to where in the code\n\u003e they're handled?\n\nIt's implemented in bitcoinj's TransactionBroadcast class. Received\nreject messages are collected and -- if a certain consensus (currently:\nhalf of connected peers) is reached -- a RejectedTransactionException is\nraised.\n\nThe handling of that exception in Bitcoin Wallet is extremely\nrudimentary. I think it still only shows the exception message. But\ncertainly I was hoping to improve on this soon.",
"sig": "f1082a03b3d20ef9c663be38f8e5a4f063b9480f1e9ed98e47475b0eaaa34cc59244e8da3dbb89517d358210ae9440333ff51702e85ac621af9d6e65daa10753"
}