📅 Original date posted:2013-06-19
📝 Original message:Bitcoin-Qt on master does send it now although it doesn't affect anything,
but as old pre-filtering versions will continue to exist, you'll always
have to be able to deserialize version messages without it.
Bitcoin version messages have always had variable length, look at how the
code is written in main.cpp. If you didn't experience issues until now all
it means is that no sufficiently old nodes were talking to yours.
The standard does not say it should appear. Read it again - BIP 37 says
about the new version message field:
If false then broadcast transactions will not be announced until a
filter{load,add,clear} command is received. *If missing or true*, no change
in protocol behaviour occurs.
On Wed, Jun 19, 2013 at 12:33 PM, Turkey Breast <turkeybreast at yahoo.com>wrote:
> It's a problem if you work with iterators to deserialize the byte stream.
> Even failing that, it's just sloppy programming. What happens in the future
> when new fields are added to the version message? It's not a big deal to
> say that this protocol version has X number of fields, that (higher)
> protocol version message has X + N number of fields. Deterministic number
> of fields per protocol version is sensical and how Bitcoin has been for a
> long time.
>
> And yes, it was a problem for me that caused a lot of confusion why this
> byte didn't exist in many version messages despite the standard saying it
> should and the code in bitcoind indicating it should. Nowhere was this
> written. It doesn't help other implementations to have an unclear behaviour
> that depends on some magic from one implementation.
>
> ------------------------------
> *From:* Mike Hearn <mike at plan99.net>
> *To:* Turkey Breast <turkeybreast at yahoo.com>
> *Cc:* "bitcoin-development at lists.sourceforge.net" <
> bitcoin-development at lists.sourceforge.net>
> *Sent:* Wednesday, June 19, 2013 11:39 AM
>
> *Subject:* Re: [Bitcoin-development] Missing fRelayTxes in version message
>
> It has to be optional because old clients don't send it, obviously.
>
> Why is this even an issue? There's no problem with variable length
> messages in any codebase that I'm aware of. Is this solving some actual
> problem?
>
>
> On Wed, Jun 19, 2013 at 12:30 AM, Turkey Breast <turkeybreast at yahoo.com>wrote:
>
> That's me. I never said to make all messages fixed length. I said to make
> a fixed number of fields per protocol. So given a protocol version number,
> you know the number of fields in a message. This is not only easier for
> parsing messages, but just good practice. I don't see why a 1 byte flag
> needs to be optional anyway.
>
> ------------------------------
> *From:* Mike Hearn <mike at plan99.net>
> *To:* Turkey Breast <turkeybreast at yahoo.com>
> *Cc:* Bitcoin Dev <bitcoin-development at lists.sourceforge.net>
> *Sent:* Tuesday, June 18, 2013 9:48 PM
> *Subject:* Re: [Bitcoin-development] Missing fRelayTxes in version message
>
> It's not a bug (although there was recently a change to make bitcoind/qt
> always send this field anyway).
>
> I don't know where Amir is going with BIP 60. Version messages have always
> been variable length. There's nothing inherent in the Bitcoin protocol that
> says all messages are fixed length, indeed, tx messages are allowed to have
> arbitrary data appended after them that gets relayed.
>
>
> On Tue, Jun 18, 2013 at 7:45 PM, Turkey Breast <turkeybreast at yahoo.com>wrote:
>
> See this BIP. I'm not sure if this is a bug or what, but it would be good
> if messages always had a fixed number of fields per protocol version.
>
> https://en.bitcoin.it/wiki/BIP_0060#Code_Updates
>
> This BIP details everything that needs to be done and proposes a protocol
> upgrade.
>
>
> ------------------------------------------------------------------------------
> This SF.net <http://sf.net/>; email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20130619/11b9537c/attachment.html>;
Mike Hearn [ARCHIVE] /
npub17t…4qgyd
2023-06-07 15:03:40
in reply to nevent1q…rmvu
Author Public Key
npub17ty4mumkv43w8wtt0xsz2jypck0gvw0j8xrcg6tpea25z2nh7meqf4qgydPublished at
2023-06-07 15:03:40Event JSON
{
"id": "c6dac8b110300c9a0c079b3bf70c0f05afc1832dcda01a6ea93a5640427df2de",
"pubkey": "f2c95df3766562e3b96b79a0254881c59e8639f23987846961cf55412a77f6f2",
"created_at": 1686150220,
"kind": 1,
"tags": [
[
"e",
"ceba0091ad9a2fc6abd2e8b950bead35c2f78a7f07c36f1b39214a94ffed3e49",
"",
"root"
],
[
"e",
"e65f2874754c1a040b48d712052d8481d6b5f111fed20c8ae357f1cdb5383e06",
"",
"reply"
],
[
"p",
"0f2093d510aaf88a0e1bf26aa961fff7868f4cf0dbd6154fad9c40c66dda8519"
]
],
"content": "📅 Original date posted:2013-06-19\n📝 Original message:Bitcoin-Qt on master does send it now although it doesn't affect anything,\nbut as old pre-filtering versions will continue to exist, you'll always\nhave to be able to deserialize version messages without it.\n\nBitcoin version messages have always had variable length, look at how the\ncode is written in main.cpp. If you didn't experience issues until now all\nit means is that no sufficiently old nodes were talking to yours.\n\nThe standard does not say it should appear. Read it again - BIP 37 says\nabout the new version message field:\nIf false then broadcast transactions will not be announced until a\nfilter{load,add,clear} command is received. *If missing or true*, no change\nin protocol behaviour occurs.\n\n\nOn Wed, Jun 19, 2013 at 12:33 PM, Turkey Breast \u003cturkeybreast at yahoo.com\u003ewrote:\n\n\u003e It's a problem if you work with iterators to deserialize the byte stream.\n\u003e Even failing that, it's just sloppy programming. What happens in the future\n\u003e when new fields are added to the version message? It's not a big deal to\n\u003e say that this protocol version has X number of fields, that (higher)\n\u003e protocol version message has X + N number of fields. Deterministic number\n\u003e of fields per protocol version is sensical and how Bitcoin has been for a\n\u003e long time.\n\u003e\n\u003e And yes, it was a problem for me that caused a lot of confusion why this\n\u003e byte didn't exist in many version messages despite the standard saying it\n\u003e should and the code in bitcoind indicating it should. Nowhere was this\n\u003e written. It doesn't help other implementations to have an unclear behaviour\n\u003e that depends on some magic from one implementation.\n\u003e\n\u003e ------------------------------\n\u003e *From:* Mike Hearn \u003cmike at plan99.net\u003e\n\u003e *To:* Turkey Breast \u003cturkeybreast at yahoo.com\u003e\n\u003e *Cc:* \"bitcoin-development at lists.sourceforge.net\" \u003c\n\u003e bitcoin-development at lists.sourceforge.net\u003e\n\u003e *Sent:* Wednesday, June 19, 2013 11:39 AM\n\u003e\n\u003e *Subject:* Re: [Bitcoin-development] Missing fRelayTxes in version message\n\u003e\n\u003e It has to be optional because old clients don't send it, obviously.\n\u003e\n\u003e Why is this even an issue? There's no problem with variable length\n\u003e messages in any codebase that I'm aware of. Is this solving some actual\n\u003e problem?\n\u003e\n\u003e\n\u003e On Wed, Jun 19, 2013 at 12:30 AM, Turkey Breast \u003cturkeybreast at yahoo.com\u003ewrote:\n\u003e\n\u003e That's me. I never said to make all messages fixed length. I said to make\n\u003e a fixed number of fields per protocol. So given a protocol version number,\n\u003e you know the number of fields in a message. This is not only easier for\n\u003e parsing messages, but just good practice. I don't see why a 1 byte flag\n\u003e needs to be optional anyway.\n\u003e\n\u003e ------------------------------\n\u003e *From:* Mike Hearn \u003cmike at plan99.net\u003e\n\u003e *To:* Turkey Breast \u003cturkeybreast at yahoo.com\u003e\n\u003e *Cc:* Bitcoin Dev \u003cbitcoin-development at lists.sourceforge.net\u003e\n\u003e *Sent:* Tuesday, June 18, 2013 9:48 PM\n\u003e *Subject:* Re: [Bitcoin-development] Missing fRelayTxes in version message\n\u003e\n\u003e It's not a bug (although there was recently a change to make bitcoind/qt\n\u003e always send this field anyway).\n\u003e\n\u003e I don't know where Amir is going with BIP 60. Version messages have always\n\u003e been variable length. There's nothing inherent in the Bitcoin protocol that\n\u003e says all messages are fixed length, indeed, tx messages are allowed to have\n\u003e arbitrary data appended after them that gets relayed.\n\u003e\n\u003e\n\u003e On Tue, Jun 18, 2013 at 7:45 PM, Turkey Breast \u003cturkeybreast at yahoo.com\u003ewrote:\n\u003e\n\u003e See this BIP. I'm not sure if this is a bug or what, but it would be good\n\u003e if messages always had a fixed number of fields per protocol version.\n\u003e\n\u003e https://en.bitcoin.it/wiki/BIP_0060#Code_Updates\n\u003e\n\u003e This BIP details everything that needs to be done and proposes a protocol\n\u003e upgrade.\n\u003e\n\u003e\n\u003e ------------------------------------------------------------------------------\n\u003e This SF.net \u003chttp://sf.net/\u003e email is sponsored by Windows:\n\u003e\n\u003e Build for Windows Store.\n\u003e\n\u003e http://p.sf.net/sfu/windows-dev2dev\n\u003e _______________________________________________\n\u003e Bitcoin-development mailing list\n\u003e Bitcoin-development at lists.sourceforge.net\n\u003e https://lists.sourceforge.net/lists/listinfo/bitcoin-development\n\u003e\n\u003e\n\u003e\n\u003e\n\u003e\n\u003e\n\u003e ------------------------------------------------------------------------------\n\u003e This SF.net email is sponsored by Windows:\n\u003e\n\u003e Build for Windows Store.\n\u003e\n\u003e http://p.sf.net/sfu/windows-dev2dev\n\u003e _______________________________________________\n\u003e Bitcoin-development mailing list\n\u003e Bitcoin-development at lists.sourceforge.net\n\u003e https://lists.sourceforge.net/lists/listinfo/bitcoin-development\n\u003e\n\u003e\n\u003e\n\u003e\n\u003e\n\u003e\n\u003e ------------------------------------------------------------------------------\n\u003e This SF.net email is sponsored by Windows:\n\u003e\n\u003e Build for Windows Store.\n\u003e\n\u003e http://p.sf.net/sfu/windows-dev2dev\n\u003e _______________________________________________\n\u003e Bitcoin-development mailing list\n\u003e Bitcoin-development at lists.sourceforge.net\n\u003e https://lists.sourceforge.net/lists/listinfo/bitcoin-development\n\u003e\n\u003e\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20130619/11b9537c/attachment.html\u003e",
"sig": "26e24e501959ff87ffec6ab4dcff471f6387fb61720b02e72e1bc9bad3ec93d2f20e88f46f56c16dc930c949f99ad72bcfe9735a6e147aded524d70b425b13a6"
}