Casey Kolderup on Nostr: is it rude to approve a PR on Github but ask a bunch of questions and/or make some ...
is it rude to approve a PR on Github but ask a bunch of questions and/or make some suggestions? I feel like this is my default PR response at work and I can’t tell if it’s a good or passive-aggressive or what. I think I’ve hit “Request changes” like four times in my entire life. (when I hit approve, I do sincerely mean that I’m okay with it getting merged in its current state)
Published at
2023-10-06 23:47:57Event JSON
{
"id": "39b4dfd84106d02022a95244ba9d0c1d8dae99d26c14afc910668fe4c637a84c",
"pubkey": "8e8d14b38bf5700a708ed937b7d89e68cbf0c0afd4adb6bd4ca52d220710bff5",
"created_at": 1696636077,
"kind": 1,
"tags": [
[
"proxy",
"https://sharetron.com/users/casey/statuses/111190741984408184",
"activitypub"
]
],
"content": "is it rude to approve a PR on Github but ask a bunch of questions and/or make some suggestions? I feel like this is my default PR response at work and I can’t tell if it’s a good or passive-aggressive or what. I think I’ve hit “Request changes” like four times in my entire life. (when I hit approve, I do sincerely mean that I’m okay with it getting merged in its current state)",
"sig": "7a2c1d1e0092e7d3321fd6d39db29cba0d34bddf3de2e7ab8308131fc8dda2fb2d4142b5296fb75ecd54f266fc461ef47b0618a4ffa05fa21c42ba75cb6e8a59"
}
