📅 Original date posted:2018-01-15
📝 Original message:I am a bit disappointed about the feedback (just received one off-list ;)
), but understand now that this mailing list is protocol-only discussions.
So - sorry for that. Anybody interested can follow progress here:
https://github.com/bitcoin/bitcoin/issues/12190
Thanks, Felix
On Thu, Jan 4, 2018 at 11:08 AM, Felix Wolfsteller <
felix.wolfsteller at gmail.com> wrote:
> Hey there
> Most source files contain the "default" copyright-header (also build by a
> script in devtools/copyright_header.py), which points out that the MIT
> license can be found in the COPYING file or at http://www.opensource.org/
> licenses/mit-license.php.
>
> However, the provided link is 1) using http where it could use https, 2)
> resulting in a redirect (https://opensource.org/licenses/mit-license.php)
> anyway.
> I am strongly in favor of using https where possible (I guess there are
> many other non-ssl links in the code base, but lets tackle the easier ones
> first).
>
> I propose that I
> 1) create a issue on github,
> 2) `sed -i` the relevant links,
> 3) create a PR on github,
> 4) come back to the mailing list.
>
> This change would affect a few hundred files I guess.
>
> A question remaining is this change would require a
> copyright-year-extension (to 2018), too.
>
> An example header can be seen e.g. here
> https://github.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7e
> f041942e9b/src/consensus/merkle.cpp#L3
>
> I'd be happy about quick feedback - do not know the culture here, yet.
>
> Have fun
> Felix
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20180115/9d29b778/attachment.html>;
Felix Wolfsteller [ARCHIVE] /
npub1a6…uj6ku
2023-06-07 18:09:13
in reply to nevent1q…ajg6
Author Public Key
npub1a6hymlrlvw73v40wmrxwe5wx6kpleywlnj25xtw988a7ypa5p5uq2uj6kuPublished at
2023-06-07 18:09:13Event JSON
{
"id": "329e43a0377627bc9cdc1c2116eefc800d6f016cbede8122610cf71916af0c3d",
"pubkey": "eeae4dfc7f63bd1655eed8ccecd1c6d583fc91df9c95432dc539fbe207b40d38",
"created_at": 1686161353,
"kind": 1,
"tags": [
[
"e",
"140375784619507b7569e89ee4e2b3cdca42f2e5b76fe09c6b1bfe6b204abce9",
"",
"root"
],
[
"e",
"9cb1dea5941a0e0e12522fdfc58a9038dc4eb0c931ce5453908914714a8ff579",
"",
"reply"
],
[
"p",
"eeae4dfc7f63bd1655eed8ccecd1c6d583fc91df9c95432dc539fbe207b40d38"
]
],
"content": "📅 Original date posted:2018-01-15\n📝 Original message:I am a bit disappointed about the feedback (just received one off-list ;)\n), but understand now that this mailing list is protocol-only discussions.\nSo - sorry for that. Anybody interested can follow progress here:\nhttps://github.com/bitcoin/bitcoin/issues/12190\nThanks, Felix\n\nOn Thu, Jan 4, 2018 at 11:08 AM, Felix Wolfsteller \u003c\nfelix.wolfsteller at gmail.com\u003e wrote:\n\n\u003e Hey there\n\u003e Most source files contain the \"default\" copyright-header (also build by a\n\u003e script in devtools/copyright_header.py), which points out that the MIT\n\u003e license can be found in the COPYING file or at http://www.opensource.org/\n\u003e licenses/mit-license.php.\n\u003e\n\u003e However, the provided link is 1) using http where it could use https, 2)\n\u003e resulting in a redirect (https://opensource.org/licenses/mit-license.php)\n\u003e anyway.\n\u003e I am strongly in favor of using https where possible (I guess there are\n\u003e many other non-ssl links in the code base, but lets tackle the easier ones\n\u003e first).\n\u003e\n\u003e I propose that I\n\u003e 1) create a issue on github,\n\u003e 2) `sed -i` the relevant links,\n\u003e 3) create a PR on github,\n\u003e 4) come back to the mailing list.\n\u003e\n\u003e This change would affect a few hundred files I guess.\n\u003e\n\u003e A question remaining is this change would require a\n\u003e copyright-year-extension (to 2018), too.\n\u003e\n\u003e An example header can be seen e.g. here\n\u003e https://github.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7e\n\u003e f041942e9b/src/consensus/merkle.cpp#L3\n\u003e\n\u003e I'd be happy about quick feedback - do not know the culture here, yet.\n\u003e\n\u003e Have fun\n\u003e Felix\n\u003e\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20180115/9d29b778/attachment.html\u003e",
"sig": "29b893b8ef3dbc45ee609624fd2b74257c5c90809cd5c0e6044ce4118c9799771118ec91c0445473be0823f1b61d2502eb6973b1fee1e3d45fcab8d44de0296a"
}