📅 Original date posted:2019-10-18
📝 Original message:> Is there a NODE_* bit we can use to pick peers that support this (useful!)
feature?
No. BIP 61 has no mechanism for advertising that a node will send REJECT
messages.
On Wed, Oct 16, 2019 at 12:43 PM John Newbery <john at johnnewbery.com> wrote:
> Following discussion on this mailing list, support for BIP 61 REJECT
> messages was not removed from Bitcoin Core in V0.19. The behaviour in that
> upcoming release is that REJECT messages are disabled by default and can be
> enabled using the `-enablebip61` command line option.
>
> Support for REJECT messages will be removed entirely in Bitcoin Core
> V0.20, expected for release in mid 2020. The PR to remove support was
> merged into Bitcoin Core's master branch this week.
>
> Adoption of new Bitcoin Core versions across reachable nodes generally
> takes several months. https://bitnodes.earn.com/dashboard/?days=365 shows
> that although v0.18 was released in May 2019, there are still several
> hundred reachable nodes on V0.17, V0.16, V0.15 and earlier software.
> Software that currently use REJECT messages from public nodes for
> troubleshooting issues therefore have plenty of time to transition to one
> of the methods listed by Marco in the email above.
>
> John
>
> On Tue, Mar 5, 2019 at 10:28 PM Marco Falke via bitcoin-dev <
> bitcoin-dev at lists.linuxfoundation.org> wrote:
>
>> Bitcoin Core may send "reject" messages as response to "tx", "block" or
>> "version" messages from a network peer when the message could not be
>> accepted.
>>
>> This feature is toggled by the `-enablebip61` command line option and has
>> been
>> disabled by default since Bitcoin Core version 0.18.0 (not yet released
>> as of
>> time of writing). Nodes on the network can not generally be trusted to
>> send
>> valid ("reject") messages, so this should only ever be used when
>> connected to a
>> trusted node. At this time, I am not aware of any software that requires
>> this
>> feature, and I would like to remove if from Bitcoin Core to make the
>> codebase
>> slimmer, easier to understand and maintain. Let us know if your
>> application
>> relies on this feature and you can not use any of the recommended
>> alternatives:
>>
>> * Testing or debugging of implementations of the Bitcoin P2P network
>> protocol
>> should be done by inspecting the log messages that are produced by a
>> recent
>> version of Bitcoin Core. Bitcoin Core logs debug messages
>> (`-debug=<category>`) to a stream (`-printtoconsole`) or to a file
>> (`-debuglogfile=<debug.log>`).
>>
>> * Testing the validity of a block can be achieved by specific RPCs:
>> - `submitblock`
>> - `getblocktemplate` with `'mode'` set to `'proposal'` for blocks with
>> potentially invalid POW
>>
>> * Testing the validity of a transaction can be achieved by specific RPCs:
>> - `sendrawtransaction`
>> - `testmempoolaccept`
>>
>> * Wallets should not use the absence of "reject" messages to indicate a
>> transaction has propagated the network, nor should wallets use "reject"
>> messages to set transaction fees. Wallets should rather use fee
>> estimation
>> to determine transaction fees and set replace-by-fee if desired. Thus,
>> they
>> could wait until the transaction has confirmed (taking into account the
>> fee
>> target they set (compare the RPC `estimatesmartfee`)) or listen for the
>> transaction announcement by other network peers to check for
>> propagation.
>>
>> I propose to remove "reject" messages from Bitcoin Core 0.19.0 unless
>> there are
>> valid concerns about its removal.
>>
>> Marco
>> _______________________________________________
>> bitcoin-dev mailing list
>> bitcoin-dev at lists.linuxfoundation.org
>> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20191018/947d583d/attachment-0001.html>;
John Newbery [ARCHIVE] /
npub1ap…608ff
2023-06-07 18:21:14
in reply to nevent1q…pwz2
Author Public Key
npub1aprq807up25mkugnhlr9nc2jkqqxd3wyrct3uj0kzhsdunaj7q8s7608ffSeen on
wss://relay.noswhere.comPublished at
2023-06-07 18:21:14Event JSON
{
"id": "0e6302f6e3c0bd0c8c0bf4e8f02f34e4d943f6bcdc181e71607bd7882df495ab",
"pubkey": "e84603bfdc0aa9bb7113bfc659e152b00066c5c41e171e49f615e0de4fb2f00f",
"created_at": 1686162074,
"kind": 1,
"tags": [
[
"e",
"fc240d6737eec3e3732c71a02d6bd551346f2bcb2e039d48bf20d899e18045d3",
"",
"root"
],
[
"e",
"4e86ab50b86a53a303c97cf8545742c5fec24ff5bb21c29aced67901043caf97",
"",
"reply"
],
[
"p",
"82205f272f995d9be742779a3c19a2ae08522ca14824c3a3b01525fb5459161e"
]
],
"content": "📅 Original date posted:2019-10-18\n📝 Original message:\u003e Is there a NODE_* bit we can use to pick peers that support this (useful!)\nfeature?\n\nNo. BIP 61 has no mechanism for advertising that a node will send REJECT\nmessages.\n\nOn Wed, Oct 16, 2019 at 12:43 PM John Newbery \u003cjohn at johnnewbery.com\u003e wrote:\n\n\u003e Following discussion on this mailing list, support for BIP 61 REJECT\n\u003e messages was not removed from Bitcoin Core in V0.19. The behaviour in that\n\u003e upcoming release is that REJECT messages are disabled by default and can be\n\u003e enabled using the `-enablebip61` command line option.\n\u003e\n\u003e Support for REJECT messages will be removed entirely in Bitcoin Core\n\u003e V0.20, expected for release in mid 2020. The PR to remove support was\n\u003e merged into Bitcoin Core's master branch this week.\n\u003e\n\u003e Adoption of new Bitcoin Core versions across reachable nodes generally\n\u003e takes several months. https://bitnodes.earn.com/dashboard/?days=365 shows\n\u003e that although v0.18 was released in May 2019, there are still several\n\u003e hundred reachable nodes on V0.17, V0.16, V0.15 and earlier software.\n\u003e Software that currently use REJECT messages from public nodes for\n\u003e troubleshooting issues therefore have plenty of time to transition to one\n\u003e of the methods listed by Marco in the email above.\n\u003e\n\u003e John\n\u003e\n\u003e On Tue, Mar 5, 2019 at 10:28 PM Marco Falke via bitcoin-dev \u003c\n\u003e bitcoin-dev at lists.linuxfoundation.org\u003e wrote:\n\u003e\n\u003e\u003e Bitcoin Core may send \"reject\" messages as response to \"tx\", \"block\" or\n\u003e\u003e \"version\" messages from a network peer when the message could not be\n\u003e\u003e accepted.\n\u003e\u003e\n\u003e\u003e This feature is toggled by the `-enablebip61` command line option and has\n\u003e\u003e been\n\u003e\u003e disabled by default since Bitcoin Core version 0.18.0 (not yet released\n\u003e\u003e as of\n\u003e\u003e time of writing). Nodes on the network can not generally be trusted to\n\u003e\u003e send\n\u003e\u003e valid (\"reject\") messages, so this should only ever be used when\n\u003e\u003e connected to a\n\u003e\u003e trusted node. At this time, I am not aware of any software that requires\n\u003e\u003e this\n\u003e\u003e feature, and I would like to remove if from Bitcoin Core to make the\n\u003e\u003e codebase\n\u003e\u003e slimmer, easier to understand and maintain. Let us know if your\n\u003e\u003e application\n\u003e\u003e relies on this feature and you can not use any of the recommended\n\u003e\u003e alternatives:\n\u003e\u003e\n\u003e\u003e * Testing or debugging of implementations of the Bitcoin P2P network\n\u003e\u003e protocol\n\u003e\u003e should be done by inspecting the log messages that are produced by a\n\u003e\u003e recent\n\u003e\u003e version of Bitcoin Core. Bitcoin Core logs debug messages\n\u003e\u003e (`-debug=\u003ccategory\u003e`) to a stream (`-printtoconsole`) or to a file\n\u003e\u003e (`-debuglogfile=\u003cdebug.log\u003e`).\n\u003e\u003e\n\u003e\u003e * Testing the validity of a block can be achieved by specific RPCs:\n\u003e\u003e - `submitblock`\n\u003e\u003e - `getblocktemplate` with `'mode'` set to `'proposal'` for blocks with\n\u003e\u003e potentially invalid POW\n\u003e\u003e\n\u003e\u003e * Testing the validity of a transaction can be achieved by specific RPCs:\n\u003e\u003e - `sendrawtransaction`\n\u003e\u003e - `testmempoolaccept`\n\u003e\u003e\n\u003e\u003e * Wallets should not use the absence of \"reject\" messages to indicate a\n\u003e\u003e transaction has propagated the network, nor should wallets use \"reject\"\n\u003e\u003e messages to set transaction fees. Wallets should rather use fee\n\u003e\u003e estimation\n\u003e\u003e to determine transaction fees and set replace-by-fee if desired. Thus,\n\u003e\u003e they\n\u003e\u003e could wait until the transaction has confirmed (taking into account the\n\u003e\u003e fee\n\u003e\u003e target they set (compare the RPC `estimatesmartfee`)) or listen for the\n\u003e\u003e transaction announcement by other network peers to check for\n\u003e\u003e propagation.\n\u003e\u003e\n\u003e\u003e I propose to remove \"reject\" messages from Bitcoin Core 0.19.0 unless\n\u003e\u003e there are\n\u003e\u003e valid concerns about its removal.\n\u003e\u003e\n\u003e\u003e Marco\n\u003e\u003e _______________________________________________\n\u003e\u003e bitcoin-dev mailing list\n\u003e\u003e bitcoin-dev at lists.linuxfoundation.org\n\u003e\u003e https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev\n\u003e\u003e\n\u003e\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20191018/947d583d/attachment-0001.html\u003e",
"sig": "3185fbcbfa40d66d27367b2e38e334ca656e24b3733c712ff3dca11b01ff834d1fe4f6e4fd9bdd73250843c94d521d9abcf9e03da5c8bd8480f4b3afe452472e"
}