📅 Original date posted:2013-10-04
📝 Original message:> There is more to a git branch than just the overall difference. Every
> single
> log message and diff is individually valuable.
When the log messages don't accurately describe the contents of the diff,
it's just misinformation and noise. Everyone starts out by wanting a neat
collection of easy to understand and review commits, but in practice it's
extremely hard to always get it.
I know how to make squashed commits, thanks. I've done LOTS of code review
in my life. I'm making a point here as one of the few people who goes
through large pull requests and reviews them line by line. It's hard,
partly because github sucks, and partly because reviewing lots of small
commits sucks.
There's nothing that makes a single large commit harder to review. It's the
same amount of code or strictly less, given the tendency for later commits
to change earlier ones. You can easily search the entire change whilst
reviewing. There are lots of things that make it easier.
FWIW inside Google the code review process is one-commit-one-review.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20131004/c73d3928/attachment.html>;
Mike Hearn [ARCHIVE] /
npub17t…4qgyd
2023-06-07 15:07:18
in reply to nevent1q…874m
Author Public Key
npub17ty4mumkv43w8wtt0xsz2jypck0gvw0j8xrcg6tpea25z2nh7meqf4qgydPublished at
2023-06-07 15:07:18Event JSON
{
"id": "02d678d68e1723b197537e14a3c6108bbc542bd2410a3778a5c7431f0929c32f",
"pubkey": "f2c95df3766562e3b96b79a0254881c59e8639f23987846961cf55412a77f6f2",
"created_at": 1686150438,
"kind": 1,
"tags": [
[
"e",
"c5a68e6f904af4bb9ba26063f532146fb896046fee8fed7dd28cab691644cf81",
"",
"root"
],
[
"e",
"944817ab01e65d450dacbbb43695e02dacb0c863df2cb78c142cf891cdc29399",
"",
"reply"
],
[
"p",
"99bec497728c848e65549d1a5257d08de97621edcb4b77073269a45dac708d59"
]
],
"content": "📅 Original date posted:2013-10-04\n📝 Original message:\u003e There is more to a git branch than just the overall difference. Every\n\u003e single\n\u003e log message and diff is individually valuable.\n\n\nWhen the log messages don't accurately describe the contents of the diff,\nit's just misinformation and noise. Everyone starts out by wanting a neat\ncollection of easy to understand and review commits, but in practice it's\nextremely hard to always get it.\n\nI know how to make squashed commits, thanks. I've done LOTS of code review\nin my life. I'm making a point here as one of the few people who goes\nthrough large pull requests and reviews them line by line. It's hard,\npartly because github sucks, and partly because reviewing lots of small\ncommits sucks.\n\nThere's nothing that makes a single large commit harder to review. It's the\nsame amount of code or strictly less, given the tendency for later commits\nto change earlier ones. You can easily search the entire change whilst\nreviewing. There are lots of things that make it easier.\n\nFWIW inside Google the code review process is one-commit-one-review.\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20131004/c73d3928/attachment.html\u003e",
"sig": "cccaa0cdf6e65f4e184cf39fe87dad940859e96167a667026c67fee1271ae19b74998d3aa4cc8f1ed0ed33710bbcf628e68d978ce6a617d6edf75c4dad499f31"
}