I'm using it here:
https://github.com/DanConwayDev/ngit-cli/blob/4f84dc460c3494286233afe9ca480d3b7c0186b1/src/lib/login/mod.rs#L294 (main branch)
https://github.com/DanConwayDev/ngit-cli/blob/e60a419510696e3fa25a35be6cba35e547b53e24/src/lib/login/mod.rs#L293 (testing-auth-with-patched-signer branch)
The main branch doesn't block when attempting to login but the patched signer branch does.
I would prefer it if it only sent a request to the signer when it has been explicitly called to sign an event. If an AUTH request is received it should attempt to sign it but do this async in the background and not block. What do you think?
DanConwayDev
npub15q…cyejr
2024-10-28 13:10:08
in reply to nevent1q…a3fh
Author Public Key
npub15qydau2hjma6ngxkl2cyar74wzyjshvl65za5k5rl69264ar2exs5cyejrSeen on
wss://relay.damus.ioPublished at
2024-10-28 13:10:08Event JSON
{
"id": "1ec237f31084eed9aa39049715fbef817f80c4218199a7a8b0fc54f165016ca3",
"pubkey": "a008def15796fba9a0d6fab04e8fd57089285d9fd505da5a83fe8aad57a3564d",
"created_at": 1730121008,
"kind": 1,
"tags": [
[
"e",
"07541591fb9caf0de62bb8baaaf23361f9e3d0a9039404693c218ae7bf2a466c",
"wss://relay.damus.io",
"root"
],
[
"e",
"1209c84731026895063cff54906a791488bff90ac1992d712cca08d6ed3ef462",
"wss://relay.damus.io",
"reply"
],
[
"r",
"73f7c34fd424cae57a0da1be1f5fd31d9b8075c0"
],
[
"a",
"30617:68d81165918100b7da43fc28f7d1fc12554466e1115886b9e7bb326f65ec4272:rust-nostr"
],
[
"p",
"68d81165918100b7da43fc28f7d1fc12554466e1115886b9e7bb326f65ec4272",
"wss://nostr.oxtr.dev/"
]
],
"content": "I'm using it here:\nhttps://github.com/DanConwayDev/ngit-cli/blob/4f84dc460c3494286233afe9ca480d3b7c0186b1/src/lib/login/mod.rs#L294 (main branch)\n\nhttps://github.com/DanConwayDev/ngit-cli/blob/e60a419510696e3fa25a35be6cba35e547b53e24/src/lib/login/mod.rs#L293 (testing-auth-with-patched-signer branch)\n\nThe main branch doesn't block when attempting to login but the patched signer branch does.\n\nI would prefer it if it only sent a request to the signer when it has been explicitly called to sign an event. If an AUTH request is received it should attempt to sign it but do this async in the background and not block. What do you think?",
"sig": "f42db14b46ddd5625a5f68c7069b4d0b7d909c44413b57e24e0d2e4de53b24c6090ff3ffb880b401750506ba8ff1f11b7439edd14eb9b11decc3792ab2e38002"
}