📅 Original date posted:2014-05-29
📝 Original message:Ok. Done.
Toshi
On Thu, May 29, 2014 at 5:06 PM, Mark Friedenbach <mark at monetize.io> wrote:
> Please make a pull request on github. It'll likely get merged quickly.
> On May 29, 2014 5:04 PM, "Toshi Morita" <toshi at peernova.com> wrote:
>
>> I ran bitcoind under valgrind and found a place where it references an
>> uninitialized variable in some cases:
>>
>> tm at tm-VirtualBox:~/bitcoind/bitcoin/src$ valgrind ./bitcoind
>> ==2337== Memcheck, a memory error detector
>> ==2337== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
>> ==2337== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info
>> ==2337== Command: ./bitcoind
>> ==2337==
>> ==2337== Conditional jump or move depends on uninitialised value(s)
>> ==2337== at 0x319176: CWallet::LoadKeyMetadata(CPubKey const&,
>> CKeyMetadata const&) (wallet.cpp:110)
>> ==2337== by 0x33645A: ReadKeyValue(CWallet*, CDataStream&,
>> CDataStream&, CWalletScanState&, std::string&, std::string&)
>> (walletdb.cpp:509)
>> ==2337== by 0x3374F0: CWalletDB::LoadWallet(CWallet*)
>> (walletdb.cpp:623)
>> ==2337== by 0x3218FD: CWallet::LoadWallet(bool&) (wallet.cpp:1485)
>> ==2337== by 0x157F16: AppInit2(boost::thread_group&) (init.cpp:958)
>> ==2337== by 0x140142: AppInit(int, char**) (bitcoind.cpp:143)
>> ==2337== by 0x13649E: main (bitcoind.cpp:180)
>> ==2337==
>>
>> The bug occurs here because nTimeFirstKey is not initialized when the
>> wallet is instantiated:
>>
>> wallet.cpp:63
>> if (!nTimeFirstKey || nCreationTime < nTimeFirstKey)
>> nTimeFirstKey = nCreationTime;
>>
>>
>> I fixed it in my fork:
>>
>> diff --git a/src/wallet.h b/src/wallet.h
>> index 9607415..b78045f 100644
>> --- a/src/wallet.h
>> +++ b/src/wallet.h
>> @@ -163,6 +163,7 @@ public:
>> nOrderPosNext = 0;
>> nNextResend = 0;
>> nLastResend = 0;
>> + nTimeFirstKey = 0;
>> }
>>
>> If this fix is ok please pull from my GitHub fork; username on GitHub is
>> tm314159.
>>
>> Toshi
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Time is money. Stop wasting it! Get your web API in 5 minutes.
>> www.restlet.com/download
>> http://p.sf.net/sfu/restlet
>> _______________________________________________
>> Bitcoin-development mailing list
>> Bitcoin-development at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20140529/2a5c17ed/attachment.html>;
Toshi Morita [ARCHIVE] /
npub1ys…7wjn3
2023-06-07 15:22:08
in reply to nevent1q…am6n
Author Public Key
npub1ys49rkspq7h9unvdedvjhqtv494wpgwgz2xv30syzcuplz3e245ss7wjn3Published at
2023-06-07 15:22:08Event JSON
{
"id": "8a55d4087040cf69106821db205ecf9ba19c4c841da92feadf782d25d76494f2",
"pubkey": "242a51da0107ae5e4d8dcb592b816ca96ae0a1c8128cc8be0416381f8a395569",
"created_at": 1686151328,
"kind": 1,
"tags": [
[
"e",
"c8bbbf81604243feb89448374a1916682ed6a1e16bc5fb903751528d86fcdc57",
"",
"root"
],
[
"e",
"5d4c0e6fd07527218e7ad40a61e11ac70af1817a3b37fff115c43ac358083436",
"",
"reply"
],
[
"p",
"1c61d995949cbfaf14f767784e166bde865c7b8783d7aa3bf0a1d014b70c0069"
]
],
"content": "📅 Original date posted:2014-05-29\n📝 Original message:Ok. Done.\n\nToshi\n\n\n\nOn Thu, May 29, 2014 at 5:06 PM, Mark Friedenbach \u003cmark at monetize.io\u003e wrote:\n\n\u003e Please make a pull request on github. It'll likely get merged quickly.\n\u003e On May 29, 2014 5:04 PM, \"Toshi Morita\" \u003ctoshi at peernova.com\u003e wrote:\n\u003e\n\u003e\u003e I ran bitcoind under valgrind and found a place where it references an\n\u003e\u003e uninitialized variable in some cases:\n\u003e\u003e\n\u003e\u003e tm at tm-VirtualBox:~/bitcoind/bitcoin/src$ valgrind ./bitcoind\n\u003e\u003e ==2337== Memcheck, a memory error detector\n\u003e\u003e ==2337== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.\n\u003e\u003e ==2337== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info\n\u003e\u003e ==2337== Command: ./bitcoind\n\u003e\u003e ==2337==\n\u003e\u003e ==2337== Conditional jump or move depends on uninitialised value(s)\n\u003e\u003e ==2337== at 0x319176: CWallet::LoadKeyMetadata(CPubKey const\u0026,\n\u003e\u003e CKeyMetadata const\u0026) (wallet.cpp:110)\n\u003e\u003e ==2337== by 0x33645A: ReadKeyValue(CWallet*, CDataStream\u0026,\n\u003e\u003e CDataStream\u0026, CWalletScanState\u0026, std::string\u0026, std::string\u0026)\n\u003e\u003e (walletdb.cpp:509)\n\u003e\u003e ==2337== by 0x3374F0: CWalletDB::LoadWallet(CWallet*)\n\u003e\u003e (walletdb.cpp:623)\n\u003e\u003e ==2337== by 0x3218FD: CWallet::LoadWallet(bool\u0026) (wallet.cpp:1485)\n\u003e\u003e ==2337== by 0x157F16: AppInit2(boost::thread_group\u0026) (init.cpp:958)\n\u003e\u003e ==2337== by 0x140142: AppInit(int, char**) (bitcoind.cpp:143)\n\u003e\u003e ==2337== by 0x13649E: main (bitcoind.cpp:180)\n\u003e\u003e ==2337==\n\u003e\u003e\n\u003e\u003e The bug occurs here because nTimeFirstKey is not initialized when the\n\u003e\u003e wallet is instantiated:\n\u003e\u003e\n\u003e\u003e wallet.cpp:63\n\u003e\u003e if (!nTimeFirstKey || nCreationTime \u003c nTimeFirstKey)\n\u003e\u003e nTimeFirstKey = nCreationTime;\n\u003e\u003e\n\u003e\u003e\n\u003e\u003e I fixed it in my fork:\n\u003e\u003e\n\u003e\u003e diff --git a/src/wallet.h b/src/wallet.h\n\u003e\u003e index 9607415..b78045f 100644\n\u003e\u003e --- a/src/wallet.h\n\u003e\u003e +++ b/src/wallet.h\n\u003e\u003e @@ -163,6 +163,7 @@ public:\n\u003e\u003e nOrderPosNext = 0;\n\u003e\u003e nNextResend = 0;\n\u003e\u003e nLastResend = 0;\n\u003e\u003e + nTimeFirstKey = 0;\n\u003e\u003e }\n\u003e\u003e\n\u003e\u003e If this fix is ok please pull from my GitHub fork; username on GitHub is\n\u003e\u003e tm314159.\n\u003e\u003e\n\u003e\u003e Toshi\n\u003e\u003e\n\u003e\u003e\n\u003e\u003e\n\u003e\u003e ------------------------------------------------------------------------------\n\u003e\u003e Time is money. Stop wasting it! Get your web API in 5 minutes.\n\u003e\u003e www.restlet.com/download\n\u003e\u003e http://p.sf.net/sfu/restlet\n\u003e\u003e _______________________________________________\n\u003e\u003e Bitcoin-development mailing list\n\u003e\u003e Bitcoin-development at lists.sourceforge.net\n\u003e\u003e https://lists.sourceforge.net/lists/listinfo/bitcoin-development\n\u003e\u003e\n\u003e\u003e\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20140529/2a5c17ed/attachment.html\u003e",
"sig": "0acefebd5b55e281ce7e57913624eaca4e60619361f88ddcfd5679e66271395d17b4ca868e99bd4079c13d4306b842b9983d65deae2f3ee2dd8ee4bd68266e93"
}