đź“… Original date posted:2012-02-07
đź“ť Original message:On Mon, Feb 6, 2012 at 5:27 PM, Wladimir <laanwj at gmail.com> wrote:
> Change BitcoinAddressValidator::MaxAddressLength to 35
> The addresses are validated with walletmodel->validateAddress which in turn
> calls CBitcoinAddress addressParsed(addr) and then isValid(). Does this work
> for the new addresses?
Should do (unless BIP 16 broke something). In fact both the GUI and
RPC commands use CBitcoinAddress and IsValid to validate addresses in
that way.
> And maybe WalletModel::sendCoins has to be changed.
> Does CScript.SetBitcoinAddress work for the new address type?
Again, should do, and it's used by the RPC commands for sending
Bitcoins as well. Really there's not a lot that needs to be changed.
I'm pretty sure even the change in MaxAddressLength is only necessary
to send coins to multisig addresses on testnet, sending them on
mainnet should just work.
Aidan Thornton [ARCHIVE] /
npub18r…na0jy
2023-06-07 03:06:37
in reply to nevent1q…dyyw
Author Public Key
npub18raeljmr9tfjcj7ncvqgkvv744a48t6lpk90xz25zlv9sla6zv4quna0jySeen on
wss://relay.nostr.bandPublished at
2023-06-07 03:06:37Event JSON
{
"id": "9b70cd86991344af03f916bf2254f9240bb040ed791d816c15c5330420e8b563",
"pubkey": "38fb9fcb632ad32c4bd3c3008b319ead7b53af5f0d8af3095417d8587fba132a",
"created_at": 1686107197,
"kind": 1,
"tags": [
[
"e",
"ed61b70e310e7def843c982fb2279c74ba8561e93b0470ad95e3abc0fde3ab55",
"",
"root"
],
[
"e",
"ce2cc4391258f69b2340608124ff9c6727fefd4d8e7f516b635dbf30e08c79f6",
"",
"reply"
],
[
"p",
"30217b018a47b99ed4c20399b44b02f70ec4f58ed77a2814a563fa28322ef722"
]
],
"content": "📅 Original date posted:2012-02-07\n📝 Original message:On Mon, Feb 6, 2012 at 5:27 PM, Wladimir \u003claanwj at gmail.com\u003e wrote:\n\u003e Change BitcoinAddressValidator::MaxAddressLength to 35\n\u003e The addresses are validated with walletmodel-\u003evalidateAddress which in turn\n\u003e calls CBitcoinAddress addressParsed(addr) and then isValid(). Does this work\n\u003e for the new addresses?\n\nShould do (unless BIP 16 broke something). In fact both the GUI and\nRPC commands use CBitcoinAddress and IsValid to validate addresses in\nthat way.\n\n\u003e And maybe WalletModel::sendCoins has to be changed.\n\u003e Does CScript.SetBitcoinAddress work for the new address type?\n\nAgain, should do, and it's used by the RPC commands for sending\nBitcoins as well. Really there's not a lot that needs to be changed.\nI'm pretty sure even the change in MaxAddressLength is only necessary\nto send coins to multisig addresses on testnet, sending them on\nmainnet should just work.",
"sig": "9c645ce4ae70c2fab8ca8eec83c9d7451199f93c3b6b3ff0e48786822d34c32196e4558a3b7b40e4fcbeb289d1b19dfbd93d232774427c9c945a88f5a9d524d3"
}