📅 Original date posted:2018-06-27
📝 Original message:hello,
On 26.6.2018 18:58, William Casarin wrote:
> as a data point, I was able to build a simple serializer[1] in about an
> afternoon. I would much prefer to use this lib in say, clightning (my
> original goal), without having to have the larger protobuf dependency.
To drive my point home, here's a PR converting the `writer` part of your
code to a protobuf-compatible version. It took me less than an hour to
write, the bigger part of which was spent orienting myself in unfamiliar
code. I assume I could do `reader` in less than that, if your
deserialization code was complete.
https://github.com/jb55/libpsbt/pull/3/files
This code produces PSBTs that my "bip174 playground" can correctly parse.
regards
m.
>
> Cheers,
>
> [1] https://github.com/jb55/libpsbt
>
>
> --
> https://jb55.com
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20180627/4d38374e/attachment.sig>;
matejcik [ARCHIVE] /
npub18g…sgac3
2023-06-07 18:13:13
in reply to nevent1q…hx60
Author Public Key
npub18g04tf4qudcsna6qfcrm55s39axx3ymrunr65gxen4rctm0zv24sasgac3Published at
2023-06-07 18:13:13Event JSON
{
"id": "94b9d8dac44fec485b00e717fc900cf850667512d39fb979455f9ccffba5a8c5",
"pubkey": "3a1f55a6a0e37109f7404e07ba52112f4c689363e4c7aa20d99d4785ede262ab",
"created_at": 1686161593,
"kind": 1,
"tags": [
[
"e",
"cde3c2f1af5ec4e3200e32c7fdbcba54b58741a9d65d38dd383e78325ee0ffcd",
"",
"root"
],
[
"e",
"69a67fa02f9467974d9845b6a67438f74e38c0214e565dd8c2921a7b1d24585c",
"",
"reply"
],
[
"p",
"32c1d9c27dfd0e394e66612d9d585c61a027adc8ad69aeb89a4a5f455080448c"
]
],
"content": "📅 Original date posted:2018-06-27\n📝 Original message:hello,\n\nOn 26.6.2018 18:58, William Casarin wrote:\n\u003e as a data point, I was able to build a simple serializer[1] in about an\n\u003e afternoon. I would much prefer to use this lib in say, clightning (my\n\u003e original goal), without having to have the larger protobuf dependency.\n\nTo drive my point home, here's a PR converting the `writer` part of your\ncode to a protobuf-compatible version. It took me less than an hour to\nwrite, the bigger part of which was spent orienting myself in unfamiliar\ncode. I assume I could do `reader` in less than that, if your\ndeserialization code was complete.\n\nhttps://github.com/jb55/libpsbt/pull/3/files\n\nThis code produces PSBTs that my \"bip174 playground\" can correctly parse.\n\nregards\nm.\n\n\u003e \n\u003e Cheers,\n\u003e \n\u003e [1] https://github.com/jb55/libpsbt\n\u003e \n\u003e \n\u003e --\n\u003e https://jb55.com\n\u003e \n\n-------------- next part --------------\nA non-text attachment was scrubbed...\nName: signature.asc\nType: application/pgp-signature\nSize: 819 bytes\nDesc: OpenPGP digital signature\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20180627/4d38374e/attachment.sig\u003e",
"sig": "d853dd9eca916d69b1b6627a1515ccf6613b9555b4f9b89c50c07823441efaae25770c76dfe000f71b807ca1fd7d6b6b42423565ef9d2826da733acb57edb791"
}