📅 Original date posted:2018-01-04
📝 Original message:Hey there
Most source files contain the "default" copyright-header (also build by a
script in devtools/copyright_header.py), which points out that the MIT
license can be found in the COPYING file or at
http://www.opensource.org/licenses/mit-license.php.
However, the provided link is 1) using http where it could use https, 2)
resulting in a redirect (https://opensource.org/licenses/mit-license.php)
anyway.
I am strongly in favor of using https where possible (I guess there are
many other non-ssl links in the code base, but lets tackle the easier ones
first).
I propose that I
1) create a issue on github,
2) `sed -i` the relevant links,
3) create a PR on github,
4) come back to the mailing list.
This change would affect a few hundred files I guess.
A question remaining is this change would require a
copyright-year-extension (to 2018), too.
An example header can be seen e.g. here
https://github.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7ef041942e9b/src/consensus/merkle.cpp#L3
I'd be happy about quick feedback - do not know the culture here, yet.
Have fun
Felix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20180104/e83674fd/attachment.html>;
Felix Wolfsteller [ARCHIVE] /
npub1a6…uj6ku
2023-06-07 18:09:12
in reply to nevent1q…8jcx
Author Public Key
npub1a6hymlrlvw73v40wmrxwe5wx6kpleywlnj25xtw988a7ypa5p5uq2uj6kuPublished at
2023-06-07 18:09:12Event JSON
{
"id": "9cb1dea5941a0e0e12522fdfc58a9038dc4eb0c931ce5453908914714a8ff579",
"pubkey": "eeae4dfc7f63bd1655eed8ccecd1c6d583fc91df9c95432dc539fbe207b40d38",
"created_at": 1686161352,
"kind": 1,
"tags": [
[
"e",
"140375784619507b7569e89ee4e2b3cdca42f2e5b76fe09c6b1bfe6b204abce9",
"",
"reply"
],
[
"p",
"a23dbf6c6cc83e14cc3df4e56cc71845f611908084cfe620e83e40c06ccdd3d0"
]
],
"content": "📅 Original date posted:2018-01-04\n📝 Original message:Hey there\nMost source files contain the \"default\" copyright-header (also build by a\nscript in devtools/copyright_header.py), which points out that the MIT\nlicense can be found in the COPYING file or at\nhttp://www.opensource.org/licenses/mit-license.php.\n\nHowever, the provided link is 1) using http where it could use https, 2)\nresulting in a redirect (https://opensource.org/licenses/mit-license.php)\nanyway.\nI am strongly in favor of using https where possible (I guess there are\nmany other non-ssl links in the code base, but lets tackle the easier ones\nfirst).\n\nI propose that I\n1) create a issue on github,\n2) `sed -i` the relevant links,\n3) create a PR on github,\n4) come back to the mailing list.\n\nThis change would affect a few hundred files I guess.\n\nA question remaining is this change would require a\ncopyright-year-extension (to 2018), too.\n\nAn example header can be seen e.g. here\nhttps://github.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7ef041942e9b/src/consensus/merkle.cpp#L3\n\nI'd be happy about quick feedback - do not know the culture here, yet.\n\nHave fun\nFelix\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20180104/e83674fd/attachment.html\u003e",
"sig": "1387b1c90334a0cff7ae7bf554b1901968fba88fcd63d347422120447ccfba7de2ccd2cc25bff4aa1e7314845f5d23117385576a2237d09fbe3ed99c69ed4def"
}