Wladimir [ARCHIVE] on Nostr: 📅 Original date posted:2014-08-23 📝 Original message:>On Sat, Aug 23, 2014 at ...
📅 Original date posted:2014-08-23
📝 Original message:>On Sat, Aug 23, 2014 at 1:38 PM, Pieter Wuille <pieter.wuille at gmail.com> >wrote:
>
> Note that we're generally aiming (though not yet enforcing) to have
> merges done through the github-merge tool, which performs the merge
> locally, shows the resulting diff, compares it with the merge done by
> github, and GnuPG signs it.
Indeed. I always use that look at and test and the merges locally
before pushing them. I never use the github merge button.
I'd recommend other people to do so as well - and as can be seen with
`git log --show-signature` it's common practice.
For browsing git history locally I find "gitk" to be a useful tool.
I'd absolutely encourage for more people to review code changes. Even
better if a few people do this through local tooling instead of the
web page. But my gut feeling is that hosting the code on github
results in many more eyes on the code overall than would be when
requiring *everyone* to use local tools. It's easy to let paranoia get
in the way of actual effectiveness.
Wladimir
Published at
2023-06-07 15:25:32Event JSON
{
"id": "97dc6fbcd588b86f988d33107d481ea3404b2a4aabe774c40701f84ed8e63bc4",
"pubkey": "30217b018a47b99ed4c20399b44b02f70ec4f58ed77a2814a563fa28322ef722",
"created_at": 1686151532,
"kind": 1,
"tags": [
[
"e",
"c005f45b1cb77392a2804d02a4c758eb9ca30d9af3fd9e762780478d5aeddb7a",
"",
"root"
],
[
"e",
"bb3868c671204f607e2f1ca0d2b17c5f29c15e17970cd6e0fb26fbc292de38f3",
"",
"reply"
],
[
"p",
"50ece7cbb2dc316af1cd5da0d62e0e1fec40f20919242c8fbedd53702fba95db"
]
],
"content": "📅 Original date posted:2014-08-23\n📝 Original message:\u003eOn Sat, Aug 23, 2014 at 1:38 PM, Pieter Wuille \u003cpieter.wuille at gmail.com\u003e \u003ewrote:\n\u003e\n\u003e Note that we're generally aiming (though not yet enforcing) to have\n\u003e merges done through the github-merge tool, which performs the merge\n\u003e locally, shows the resulting diff, compares it with the merge done by\n\u003e github, and GnuPG signs it.\n\nIndeed. I always use that look at and test and the merges locally\nbefore pushing them. I never use the github merge button.\n\nI'd recommend other people to do so as well - and as can be seen with\n`git log --show-signature` it's common practice.\n\nFor browsing git history locally I find \"gitk\" to be a useful tool.\n\nI'd absolutely encourage for more people to review code changes. Even\nbetter if a few people do this through local tooling instead of the\nweb page. But my gut feeling is that hosting the code on github\nresults in many more eyes on the code overall than would be when\nrequiring *everyone* to use local tools. It's easy to let paranoia get\nin the way of actual effectiveness.\n\nWladimir",
"sig": "1156079db4b239d9bf98655351d44c96fa55927bc28e629597eadc8d30011dbbb082bfb001b6903690887e0daf617d0ee0ff18f6b49432c9c44e6887ba887531"
}