thanks for the proposal. its a typo fix for the word 'download'.
ngit sent the 48 previous commits as part of the patch set. I think ngit did this because you hadn't pulled from origin into the 'main' branch but instead opted to pull directly into your feature branch. ngit currently assumes that commit not in the 'main' branch are part of the feature and includes them in the proposal. does that sound right?
perhaps ngit should check against 'origin/main' (or 'origin/master') instead. or it look for a remote with a url most similar to that in the repo event, and look for '[remote-name]/main'. that might be more robust.
it should also sense check the number of commits
perhaps it shouldn't make any assumptions and present a list of recent commits in the current branch for the user to choose from
DanConwayDev
npub15q…cyejr
2024-03-02 21:31:21
in reply to nevent1q…xmll
Author Public Key
npub15qydau2hjma6ngxkl2cyar74wzyjshvl65za5k5rl69264ar2exs5cyejrPublished at
2024-03-02 21:31:21Event JSON
{
"id": "570b2c877389222b5b4dcd5965fc6197a43ccf1d6638e2fa229fe1f7546fbf0d",
"pubkey": "a008def15796fba9a0d6fab04e8fd57089285d9fd505da5a83fe8aad57a3564d",
"created_at": 1709415081,
"kind": 1,
"tags": [
[
"e",
"6cb4b8af5cc7a96a7b980f2700ef797da2863efb6a3ab2fdccf778c321d4a2c4",
"wss://relay.damus.io",
"root"
],
[
"e",
"6cb4b8af5cc7a96a7b980f2700ef797da2863efb6a3ab2fdccf778c321d4a2c4",
"wss://relay.damus.io",
"reply"
],
[
"r",
"26689f97810fc656c7134c76e2a37d33b2e40ce7"
],
[
"a",
"30617:a008def15796fba9a0d6fab04e8fd57089285d9fd505da5a83fe8aad57a3564d:ngit"
],
[
"p",
"edfa27d49d2af37ee331e1225bb6ed1912c6d999281b36d8018ad99bc3573c29"
]
],
"content": "thanks for the proposal. its a typo fix for the word 'download'.\n\nngit sent the 48 previous commits as part of the patch set. I think ngit did this because you hadn't pulled from origin into the 'main' branch but instead opted to pull directly into your feature branch. ngit currently assumes that commit not in the 'main' branch are part of the feature and includes them in the proposal. does that sound right?\n\nperhaps ngit should check against 'origin/main' (or 'origin/master') instead. or it look for a remote with a url most similar to that in the repo event, and look for '[remote-name]/main'. that might be more robust.\n\nit should also sense check the number of commits\n\nperhaps it shouldn't make any assumptions and present a list of recent commits in the current branch for the user to choose from",
"sig": "48483668198af1c8bb3ba58d30a1fbf7678dcf56093c737cc8987eab2e2dff88dd1e72be2fcd99ea488613db43d2df928c4313e452e8aefc6e4da5500beec3fb"
}