📅 Original date posted:2016-02-01
📝 Original message:Thanks for getting this started, Luke.
Noticeably absent here is the "default_witness_commitment" key, as
added by the current reference implementation[0].
I assume (please correct me if I'm wrong) that this has been omitted
for the sake of having clients create the commitment themselves as
opposed to having it provided to them.
I don't think that the two approaches (providing the default
commitment for the complete tx set as well as the ability to create it
from chosen transactions) are at odds with each-other, rather it
merely allows for a simpler approach for those who are taking tx's
as-is from bitcoind. It's obviously important for the clients to be
able to chose tx's and create commitments as they desire, but it's
equally important to allow for simpler use-cases.
The issue in particular here is that a non-trivial burden is thrust
upon mining software, increasing the odds of bugs in the process. I'd
like to point out that this is not a theoretical argument. I've
already fixed a handful of bugs relating to serialization or
commitment creation in the mining/pool software that I've worked on
for segwit [1][2][3][4]. Asking them to handle more serialization and
calculation of complex structures needlessly increases the complexity
for zero benefit in the case where the tx's are to be used as-is.
I'll PR this change to the BIP, as I can't really come up with an
argument against. At worst, it can simply be ignored.
[0]: https://github.com/sipa/bitcoin/blob/segwit/src/rpcmining.cpp#L590
[1]: https://github.com/bitcoin/libblkmaker/commit/22f6e42844aa14ed0037ebf12a734f07e63533d7
[2]: https://github.com/bitcoin/libblkmaker/commit/15e2c35bf69c997488e37147cf062dfa925b4912
[3]: https://github.com/bitcoin/libblkmaker/commit/9a5799891e0f3590779b8e5a993a7b306088e2fa
[4]: https://github.com/theuni/ckpool/commit/7d84b1d76b39591cc1c1ef495ebec513cb19a08e
Regards,
Cory
On Sat, Jan 30, 2016 at 1:50 PM, Luke Dashjr via bitcoin-dev
<bitcoin-dev at lists.linuxfoundation.org> wrote:
> I've completed an initial draft of a BIP for updating getblocktemplate for
> segregated witness here:
> https://github.com/luke-jr/bips/blob/segwit_gbt/bip-segwit-gbt.mediawiki
>
> Please review and comment (especially with regard to the changes in the
> sigoplimits handling).
>
> (Note: libblkmaker's reference implementation is at this time incompatible
> with the "last output" rule in this BIP.)
>
> Thanks,
>
> Luke
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
Cory Fields [ARCHIVE] /
npub19r…yj32s
2023-06-07 17:48:19
in reply to nevent1q…ym7k
Author Public Key
npub19r53ufymeycp9wzk3yzru55y5u46e4vva2lj7nak4zrn6yhrna7qsyj32sPublished at
2023-06-07 17:48:19Event JSON
{
"id": "5f70ca20f05e18f0f1b7c27f56922b7e2b9a9d98017fa2f3e1ead67a19bbee8d",
"pubkey": "28e91e249bc93012b85689043e5284a72bacd58ceabf2f4fb6a8873d12e39f7c",
"created_at": 1686160099,
"kind": 1,
"tags": [
[
"e",
"d1f8e12cb560f51e30f188d7bc5ff5d0f6f33791d2e90d0bdd13cdcbe911293b",
"",
"reply"
],
[
"p",
"a23dbf6c6cc83e14cc3df4e56cc71845f611908084cfe620e83e40c06ccdd3d0"
]
],
"content": "📅 Original date posted:2016-02-01\n📝 Original message:Thanks for getting this started, Luke.\n\nNoticeably absent here is the \"default_witness_commitment\" key, as\nadded by the current reference implementation[0].\n\nI assume (please correct me if I'm wrong) that this has been omitted\nfor the sake of having clients create the commitment themselves as\nopposed to having it provided to them.\n\nI don't think that the two approaches (providing the default\ncommitment for the complete tx set as well as the ability to create it\nfrom chosen transactions) are at odds with each-other, rather it\nmerely allows for a simpler approach for those who are taking tx's\nas-is from bitcoind. It's obviously important for the clients to be\nable to chose tx's and create commitments as they desire, but it's\nequally important to allow for simpler use-cases.\n\nThe issue in particular here is that a non-trivial burden is thrust\nupon mining software, increasing the odds of bugs in the process. I'd\nlike to point out that this is not a theoretical argument. I've\nalready fixed a handful of bugs relating to serialization or\ncommitment creation in the mining/pool software that I've worked on\nfor segwit [1][2][3][4]. Asking them to handle more serialization and\ncalculation of complex structures needlessly increases the complexity\nfor zero benefit in the case where the tx's are to be used as-is.\n\nI'll PR this change to the BIP, as I can't really come up with an\nargument against. At worst, it can simply be ignored.\n\n[0]: https://github.com/sipa/bitcoin/blob/segwit/src/rpcmining.cpp#L590\n[1]: https://github.com/bitcoin/libblkmaker/commit/22f6e42844aa14ed0037ebf12a734f07e63533d7\n[2]: https://github.com/bitcoin/libblkmaker/commit/15e2c35bf69c997488e37147cf062dfa925b4912\n[3]: https://github.com/bitcoin/libblkmaker/commit/9a5799891e0f3590779b8e5a993a7b306088e2fa\n[4]: https://github.com/theuni/ckpool/commit/7d84b1d76b39591cc1c1ef495ebec513cb19a08e\n\nRegards,\nCory\n\nOn Sat, Jan 30, 2016 at 1:50 PM, Luke Dashjr via bitcoin-dev\n\u003cbitcoin-dev at lists.linuxfoundation.org\u003e wrote:\n\u003e I've completed an initial draft of a BIP for updating getblocktemplate for\n\u003e segregated witness here:\n\u003e https://github.com/luke-jr/bips/blob/segwit_gbt/bip-segwit-gbt.mediawiki\n\u003e\n\u003e Please review and comment (especially with regard to the changes in the\n\u003e sigoplimits handling).\n\u003e\n\u003e (Note: libblkmaker's reference implementation is at this time incompatible\n\u003e with the \"last output\" rule in this BIP.)\n\u003e\n\u003e Thanks,\n\u003e\n\u003e Luke\n\u003e _______________________________________________\n\u003e bitcoin-dev mailing list\n\u003e bitcoin-dev at lists.linuxfoundation.org\n\u003e https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev",
"sig": "52b886a139affb3bb92475f5b6a4557a55357f1f66bccbdb14b8fc4bd35d3e551614a262b64a865e546b96ded321434ed5a5616e103e7c089de66faa660523bf"
}