Dave Anderson on Nostr: It's funny how github's API vomits out _so much_ information about pull requests, but ...
It's funny how github's API vomits out _so much_ information about pull requests, but nowhere in that pile of data can you find the PR's merge base.
If you're about to go "akshually the response contains base.sha", I hope you didn't write any CI code based on that assumption, because it's wrong:
https://github.com/orgs/community/discussions/39880 . base.sha references _some_ commit on the target branch, which could be before/on/after the desired merge base.
Published at
2024-07-24 23:20:46Event JSON
{
"id": "74b0746f851a8cf629f29782943d51812372a4f5ad6bc9c2e8038b7423ea9b87",
"pubkey": "d2bca0280c4620e67261dec7efe7eec4b1ca32ed37c84958d6c76b57526132c5",
"created_at": 1721863246,
"kind": 1,
"tags": [
[
"proxy",
"https://hachyderm.io/users/danderson/statuses/112844029695715362",
"activitypub"
]
],
"content": "It's funny how github's API vomits out _so much_ information about pull requests, but nowhere in that pile of data can you find the PR's merge base.\n\nIf you're about to go \"akshually the response contains base.sha\", I hope you didn't write any CI code based on that assumption, because it's wrong: https://github.com/orgs/community/discussions/39880 . base.sha references _some_ commit on the target branch, which could be before/on/after the desired merge base.",
"sig": "8a207244dc26a22864e5fb471e22c102181d9b19af7a6c28a8c37477ca61b546c17ffd35cc36a5367d2ba1c6cb014b29663e2a5fb192d8940ce62b7a6a4a1183"
}