📅 Original date posted:2014-07-16
📝 Original message:I will change the bitcoinj implementation and propose a new test vector.
On 07/16/2014 11:29 AM, Mike Hearn wrote:
> Yes sorry, you're right, the issue starts with the null code point.
> Python seems to have problems starting there too. It might work if we
> took that out.
>
>
> On Wed, Jul 16, 2014 at 11:17 AM, Andreas Schildbach
> <andreas at schildbach.de <mailto:andreas at schildbach.de>> wrote:
>
> Guys, you are always talking about the Unicode astral plane, but in fact
> its a plain old (ASCII) control character where this problem starts and
> likely ends: \u0000.
>
> Let's ban/filter ISO control characters and be done with it. Most
> control characters will never be enterable by any keyboard into a
> password field. Of course I assume that Character.isISOControl() works
> consistently across platforms.
>
> http://docs.oracle.com/javase/7/docs/api/java/lang/Character.html#isISOControl%28char%29
>
>
> On 07/16/2014 12:23 AM, Aaron Voisine wrote:
> > If the user creates a password on an iOS device with an astral
> > character and then can't enter that password on a JVM wallet, that
> > sucks. If JVMs really can't support unicode NFC then that's a strong
> > case to limit the spec to the subset of unicode that all popular
> > platforms can support, but it sounds like it might just be a JVM
> > string library bug that could hopefully be reported and fixed. I get
> > the same result as in the test case using apple's
> > CFStringNormalize(passphrase, kCFStringNormalizationFormC);
> >
> > Aaron Voisine
> > breadwallet.com <http://breadwallet.com>;
> >
> >
> > On Tue, Jul 15, 2014 at 11:20 AM, Mike Hearn <mike at plan99.net
> <mailto:mike at plan99.net>> wrote:
> >> Yes, we know, Andreas' code is indeed doing normalisation.
> >>
> >> However it appears the output bytes end up being different. What
> I get back
> >> is:
> >>
> >> cf930001303430300166346139
> >>
> >> vs
> >>
> >> cf9300f0909080f09f92a9
> >>
> >> from the spec.
> >>
> >> I'm not sure why. It appears this is due to the character from
> the astral
> >> planes. Java is old and uses 16 bit characters internally - it
> wouldn't
> >> surprise me if there's some weirdness that means it doesn't/won't
> support
> >> this kind of thing.
> >>
> >> I recommend instead that any implementation that wishes to be
> compatible
> >> with JVM based wallets (I suspect Android is the same) just
> refuse any
> >> passphrase that includes characters outside the BMP. At least
> unless someone
> >> can find a fix. I somehow doubt this will really hurt anyone.
> >>
> >>
> ------------------------------------------------------------------------------
> >> Want fast and easy access to all the code in your enterprise?
> Index and
> >> search up to 200,000 lines of code with a free copy of Black Duck
> >> Code Sight - the same software that powers the world's largest code
> >> search on Ohloh, the Black Duck Open Hub! Try it now.
> >> http://p.sf.net/sfu/bds
> >> _______________________________________________
> >> Bitcoin-development mailing list
> >> Bitcoin-development at lists.sourceforge.net
> <mailto:Bitcoin-development at lists.sourceforge.net>
> >> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
> >>
> >
> >
> ------------------------------------------------------------------------------
> > Want fast and easy access to all the code in your enterprise?
> Index and
> > search up to 200,000 lines of code with a free copy of Black Duck
> > Code Sight - the same software that powers the world's largest code
> > search on Ohloh, the Black Duck Open Hub! Try it now.
> > http://p.sf.net/sfu/bds
> >
>
>
>
> ------------------------------------------------------------------------------
> Want fast and easy access to all the code in your enterprise? Index and
> search up to 200,000 lines of code with a free copy of Black Duck
> Code Sight - the same software that powers the world's largest code
> search on Ohloh, the Black Duck Open Hub! Try it now.
> http://p.sf.net/sfu/bds
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development at lists.sourceforge.net
> <mailto:Bitcoin-development at lists.sourceforge.net>
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
>
>
> ------------------------------------------------------------------------------
> Want fast and easy access to all the code in your enterprise? Index and
> search up to 200,000 lines of code with a free copy of Black Duck
> Code Sight - the same software that powers the world's largest code
> search on Ohloh, the Black Duck Open Hub! Try it now.
> http://p.sf.net/sfu/bds
>
>
>
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
Andreas Schildbach [ARCHIVE] /
npub1xg…adsv7
2023-06-07 15:23:52
in reply to nevent1q…7mm3
Author Public Key
npub1xg2m84malu0cfm4444r0kysx4rgk27e75aj6sz6538kw8fcz627qeadsv7Published at
2023-06-07 15:23:52Event JSON
{
"id": "73f5b37a284e650a5044da73a29a9061d7b776308919208b99c5eb063c5a65ec",
"pubkey": "3215b3d77dff1f84eeb5ad46fb1206a8d1657b3ea765a80b5489ece3a702d2bc",
"created_at": 1686151432,
"kind": 1,
"tags": [
[
"e",
"60726055f5690f49a0698605fd9e440f1a7b0fbf2e702b7f0382a84f86474ca9",
"",
"root"
],
[
"e",
"b3dccd2478713a92855fec7526500634facb4d4c3274724bf8d2f8ec5f1a83fa",
"",
"reply"
],
[
"p",
"f2c95df3766562e3b96b79a0254881c59e8639f23987846961cf55412a77f6f2"
]
],
"content": "📅 Original date posted:2014-07-16\n📝 Original message:I will change the bitcoinj implementation and propose a new test vector.\n\n\n\nOn 07/16/2014 11:29 AM, Mike Hearn wrote:\n\u003e Yes sorry, you're right, the issue starts with the null code point.\n\u003e Python seems to have problems starting there too. It might work if we\n\u003e took that out.\n\u003e \n\u003e \n\u003e On Wed, Jul 16, 2014 at 11:17 AM, Andreas Schildbach\n\u003e \u003candreas at schildbach.de \u003cmailto:andreas at schildbach.de\u003e\u003e wrote:\n\u003e \n\u003e Guys, you are always talking about the Unicode astral plane, but in fact\n\u003e its a plain old (ASCII) control character where this problem starts and\n\u003e likely ends: \\u0000.\n\u003e \n\u003e Let's ban/filter ISO control characters and be done with it. Most\n\u003e control characters will never be enterable by any keyboard into a\n\u003e password field. Of course I assume that Character.isISOControl() works\n\u003e consistently across platforms.\n\u003e \n\u003e http://docs.oracle.com/javase/7/docs/api/java/lang/Character.html#isISOControl%28char%29\n\u003e \n\u003e \n\u003e On 07/16/2014 12:23 AM, Aaron Voisine wrote:\n\u003e \u003e If the user creates a password on an iOS device with an astral\n\u003e \u003e character and then can't enter that password on a JVM wallet, that\n\u003e \u003e sucks. If JVMs really can't support unicode NFC then that's a strong\n\u003e \u003e case to limit the spec to the subset of unicode that all popular\n\u003e \u003e platforms can support, but it sounds like it might just be a JVM\n\u003e \u003e string library bug that could hopefully be reported and fixed. I get\n\u003e \u003e the same result as in the test case using apple's\n\u003e \u003e CFStringNormalize(passphrase, kCFStringNormalizationFormC);\n\u003e \u003e\n\u003e \u003e Aaron Voisine\n\u003e \u003e breadwallet.com \u003chttp://breadwallet.com\u003e\n\u003e \u003e\n\u003e \u003e\n\u003e \u003e On Tue, Jul 15, 2014 at 11:20 AM, Mike Hearn \u003cmike at plan99.net\n\u003e \u003cmailto:mike at plan99.net\u003e\u003e wrote:\n\u003e \u003e\u003e Yes, we know, Andreas' code is indeed doing normalisation.\n\u003e \u003e\u003e\n\u003e \u003e\u003e However it appears the output bytes end up being different. What\n\u003e I get back\n\u003e \u003e\u003e is:\n\u003e \u003e\u003e\n\u003e \u003e\u003e cf930001303430300166346139\n\u003e \u003e\u003e\n\u003e \u003e\u003e vs\n\u003e \u003e\u003e\n\u003e \u003e\u003e cf9300f0909080f09f92a9\n\u003e \u003e\u003e\n\u003e \u003e\u003e from the spec.\n\u003e \u003e\u003e\n\u003e \u003e\u003e I'm not sure why. It appears this is due to the character from\n\u003e the astral\n\u003e \u003e\u003e planes. Java is old and uses 16 bit characters internally - it\n\u003e wouldn't\n\u003e \u003e\u003e surprise me if there's some weirdness that means it doesn't/won't\n\u003e support\n\u003e \u003e\u003e this kind of thing.\n\u003e \u003e\u003e\n\u003e \u003e\u003e I recommend instead that any implementation that wishes to be\n\u003e compatible\n\u003e \u003e\u003e with JVM based wallets (I suspect Android is the same) just\n\u003e refuse any\n\u003e \u003e\u003e passphrase that includes characters outside the BMP. At least\n\u003e unless someone\n\u003e \u003e\u003e can find a fix. I somehow doubt this will really hurt anyone.\n\u003e \u003e\u003e\n\u003e \u003e\u003e\n\u003e ------------------------------------------------------------------------------\n\u003e \u003e\u003e Want fast and easy access to all the code in your enterprise?\n\u003e Index and\n\u003e \u003e\u003e search up to 200,000 lines of code with a free copy of Black Duck\n\u003e \u003e\u003e Code Sight - the same software that powers the world's largest code\n\u003e \u003e\u003e search on Ohloh, the Black Duck Open Hub! Try it now.\n\u003e \u003e\u003e http://p.sf.net/sfu/bds\n\u003e \u003e\u003e _______________________________________________\n\u003e \u003e\u003e Bitcoin-development mailing list\n\u003e \u003e\u003e Bitcoin-development at lists.sourceforge.net\n\u003e \u003cmailto:Bitcoin-development at lists.sourceforge.net\u003e\n\u003e \u003e\u003e https://lists.sourceforge.net/lists/listinfo/bitcoin-development\n\u003e \u003e\u003e\n\u003e \u003e\n\u003e \u003e\n\u003e ------------------------------------------------------------------------------\n\u003e \u003e Want fast and easy access to all the code in your enterprise?\n\u003e Index and\n\u003e \u003e search up to 200,000 lines of code with a free copy of Black Duck\n\u003e \u003e Code Sight - the same software that powers the world's largest code\n\u003e \u003e search on Ohloh, the Black Duck Open Hub! Try it now.\n\u003e \u003e http://p.sf.net/sfu/bds\n\u003e \u003e\n\u003e \n\u003e \n\u003e \n\u003e ------------------------------------------------------------------------------\n\u003e Want fast and easy access to all the code in your enterprise? Index and\n\u003e search up to 200,000 lines of code with a free copy of Black Duck\n\u003e Code Sight - the same software that powers the world's largest code\n\u003e search on Ohloh, the Black Duck Open Hub! Try it now.\n\u003e http://p.sf.net/sfu/bds\n\u003e _______________________________________________\n\u003e Bitcoin-development mailing list\n\u003e Bitcoin-development at lists.sourceforge.net\n\u003e \u003cmailto:Bitcoin-development at lists.sourceforge.net\u003e\n\u003e https://lists.sourceforge.net/lists/listinfo/bitcoin-development\n\u003e \n\u003e \n\u003e \n\u003e \n\u003e ------------------------------------------------------------------------------\n\u003e Want fast and easy access to all the code in your enterprise? Index and\n\u003e search up to 200,000 lines of code with a free copy of Black Duck\n\u003e Code Sight - the same software that powers the world's largest code\n\u003e search on Ohloh, the Black Duck Open Hub! Try it now.\n\u003e http://p.sf.net/sfu/bds\n\u003e \n\u003e \n\u003e \n\u003e _______________________________________________\n\u003e Bitcoin-development mailing list\n\u003e Bitcoin-development at lists.sourceforge.net\n\u003e https://lists.sourceforge.net/lists/listinfo/bitcoin-development\n\u003e",
"sig": "d5d54dbb99fb6cc67692fd1587f0a73d33343b226b070eec6b0dd4e23b98a4b30bd2f5be6a277130b054e608e1fc7a232feb51fdc8b23f77f4938ecd095ec244"
}