📅 Original date posted:2017-03-13
📝 Original message:On Sunday, March 12, 2017 3:50:27 PM shaolinfry via bitcoin-dev wrote:
> // mandatory segwit activation between Oct 1st 2017 and Nov 15th 2017
> inclusive if (pindex->GetMedianTimePast() >= 1538352000 &&
> pindex->GetMedianTimePast() <= 1510704000 &&
> !IsWitnessEnabled(pindex->pprev, chainparams.GetConsensus())) {
> if (!((pindex->nVersion & VERSIONBITS_TOP_MASK) ==
> VERSIONBITS_TOP_BITS) && (pindex->nVersion & VersionBitsMask(params,
> Consensus::DEPLOYMENT_SEGWIT)) != 0) {
> return state.DoS(2, error("ConnectBlock(): relayed block must
> signal for segwit, please upgrade"), REJECT_INVALID,
> "bad-no-segwit");
> }
> }
I don't think this is actually BIP 9 compatible. Once activated, the bit loses
its meaning and should not be set. So you need to check that it hasn't locked-
in already...
Also, IMO this should tolerate as many as 5% minus one non-signalling blocks.
Disclaimer: This are technical suggestions, and do not imply endorsement of
the idea.
Luke
Luke Dashjr [ARCHIVE] /
npub1tf…rfq0n
2023-06-07 17:57:14
in reply to nevent1q…qxll
Author Public Key
npub1tfk373zg9dnmtvxnpnq7s2dkdgj37rwfj3yrwld7830qltmv8qps8rfq0nPublished at
2023-06-07 17:57:14Event JSON
{
"id": "7a129852bcbff5c83b40d8b2461ab6c5557841563ef461e7cabbed4a1daff1ae",
"pubkey": "5a6d1f44482b67b5b0d30cc1e829b66a251f0dc99448377dbe3c5e0faf6c3803",
"created_at": 1686160634,
"kind": 1,
"tags": [
[
"e",
"c85e331219b41163c53d11241cf7a40c8747f1688f2c56a907ca61b00451e77b",
"",
"root"
],
[
"e",
"d37ea0619c9fb2201cbda3ac057b6dbbe695be7fbd8914407ffef766db777b1c",
"",
"reply"
],
[
"p",
"512c64351a85e9323c34af13b4dfcf320615bacb09132ae6da9ce671b7942825"
]
],
"content": "📅 Original date posted:2017-03-13\n📝 Original message:On Sunday, March 12, 2017 3:50:27 PM shaolinfry via bitcoin-dev wrote:\n\u003e // mandatory segwit activation between Oct 1st 2017 and Nov 15th 2017\n\u003e inclusive if (pindex-\u003eGetMedianTimePast() \u003e= 1538352000 \u0026\u0026\n\u003e pindex-\u003eGetMedianTimePast() \u003c= 1510704000 \u0026\u0026\n\u003e !IsWitnessEnabled(pindex-\u003epprev, chainparams.GetConsensus())) {\n\u003e if (!((pindex-\u003enVersion \u0026 VERSIONBITS_TOP_MASK) ==\n\u003e VERSIONBITS_TOP_BITS) \u0026\u0026 (pindex-\u003enVersion \u0026 VersionBitsMask(params,\n\u003e Consensus::DEPLOYMENT_SEGWIT)) != 0) {\n\u003e return state.DoS(2, error(\"ConnectBlock(): relayed block must\n\u003e signal for segwit, please upgrade\"), REJECT_INVALID,\n\u003e \"bad-no-segwit\");\n\u003e }\n\u003e }\n\nI don't think this is actually BIP 9 compatible. Once activated, the bit loses \nits meaning and should not be set. So you need to check that it hasn't locked-\nin already...\n\nAlso, IMO this should tolerate as many as 5% minus one non-signalling blocks.\n\nDisclaimer: This are technical suggestions, and do not imply endorsement of \nthe idea.\n\nLuke",
"sig": "72ed3da49b548d014f2254360ed46bbe264cf62442e3d8faef94a5c5694cd6faf5d64057f8b42d1381893cc7eff5ba0460731713bd188043c381cb20a887037e"
}