in my hobby relay rewriting work at the moment i'm literally in the midst of implementing a correct and nicely constructed subscription handler
the stuff that fiatjaf wrote uses 3 separate libraries for no reason and doesn't integrate the websockets and subscriptions more cleanly... subscriptions are attached to specific sockets so if the socket closes the sub needs to die and query processing not check the filter anymore...
you can go look at some of his repos now, i forget which one, where he actually says that if you "don't use this properly" you end up with a massive resource leak... yeah, nicholascageduhmeme.jpg and it is so bad that i'm rewriting my whole relay engine from the ground up because fixing it made me pull in his incredible garbage spaghetti mess of way too many imports and disconnected stuff and unsafe use of concurrency and complicated context programming and his phobia about badger and mutexes lol
let's just say that it is all written almost exactly the way i wouldn't
so yeah that's why i spotted that i figured you must be writing some subscription handling code, i will likely have some commentary about the subject in coming weeks
mleku / mleku ✝Ⓐ☯︎
npub1fj…mleku
2024-08-25 22:05:12
in reply to nevent1q…2fm4
Author Public Key
npub1fjqqy4a93z5zsjwsfxqhc2764kvykfdyttvldkkkdera8dr78vhsmmlekuPublished at
2024-08-25 22:05:12Event JSON
{
"id": "a673e83799685ee0cfa9fa3dbdcbd62912d00bee270604f4541f31f5141d279f",
"pubkey": "4c800257a588a82849d049817c2bdaad984b25a45ad9f6dad66e47d3b47e3b2f",
"created_at": 1724623512,
"kind": 1,
"tags": [
[
"p",
"4bc7982c4ee4078b2ada5340ae673f18d3b6a664b1f97e8d6799e6074cb5c39d",
"wss://nos.lol/",
"Shinoa Fores 死の灰"
],
[
"e",
"dce8e60012483231ecad8d68717cfb209950f933b1e7b8c5f857738a80c77782",
"wss://nos.lol/",
"root",
"4bc7982c4ee4078b2ada5340ae673f18d3b6a664b1f97e8d6799e6074cb5c39d"
],
[
"e",
"f079278cc1ccd384fd9fc8b2c3abe1d68ecb6ff73a4d608050852916183d9661",
"wss://nos.lol",
"mention"
],
[
"e",
"77042fcf1f60a62a6c056ebe6412843b86ab166ac72c2e3b8e350e985132f9fc",
"wss://nos.lol/",
"reply",
"4bc7982c4ee4078b2ada5340ae673f18d3b6a664b1f97e8d6799e6074cb5c39d"
],
[
"client",
"Coracle",
"31990:97c70a44366a6535c145b333f973ea86dfdc2d7a99da618c40c64705ad98e322:1685968093690"
]
],
"content": "in my hobby relay rewriting work at the moment i'm literally in the midst of implementing a correct and nicely constructed subscription handler\n\nthe stuff that fiatjaf wrote uses 3 separate libraries for no reason and doesn't integrate the websockets and subscriptions more cleanly... subscriptions are attached to specific sockets so if the socket closes the sub needs to die and query processing not check the filter anymore...\n\nyou can go look at some of his repos now, i forget which one, where he actually says that if you \"don't use this properly\" you end up with a massive resource leak... yeah, nicholascageduhmeme.jpg and it is so bad that i'm rewriting my whole relay engine from the ground up because fixing it made me pull in his incredible garbage spaghetti mess of way too many imports and disconnected stuff and unsafe use of concurrency and complicated context programming and his phobia about badger and mutexes lol\n\nlet's just say that it is all written almost exactly the way i wouldn't\n\nso yeah that's why i spotted that i figured you must be writing some subscription handling code, i will likely have some commentary about the subject in coming weeks",
"sig": "3427e4da85c69650ada535a9024b1102a0b4a66b8d4b5879ec143a50a403c3b6a9072e710d5832a6976dd98ffa0ea921a9c48adea71f307f4104b18eb6b6fe91"
}