📅 Original date posted:2022-01-01
📝 Original message:I've looked at these PR's and they seem, frankly, bizarre.
You've essentially noticed that if an attacker can run commands on your system, they can run commands on your system.
If you can convince someone to run arbitrary commands, which is what a desktop shortcut or a command argument _is_ at a fundamental level, you own their system. I fail to see how this has anything to do with Core at all.
Daniel Edgecumbe | esotericnonsense
email at esotericnonsense.com | https://esotericnonsense.com
On Sat, Jan 1, 2022, at 21:03, Prayank via bitcoin-dev wrote:
> Hello World,
>
> What?
>
> Remove all *notify options from Bitcoin Core (full node implementation
> used by 99% nodes)
>
> Or one of the below:
>
> notifications.dat
> not use system() in runCommand()
> Use a new setting in settings.json file, notifypolicy which is 0 by
> default (restricted) and can be set to 1 (unrestricted)
>
> Why?
>
> They can help attackers in doing almost anything on machines running
> Bitcoin Core with some social engineering.
>
> How?
>
> Everything is explained several times in different issues, PRs etc. to
> different people including few reviewers who even NACKed a PR that
> would help in adding such options but with some documentation. I won't
> comment much about the reviewers but some of them were clueless about
> issue and how things work.
>
> Example: Calling something misleading and ludicrous when you don't even
> know what works in Windows shortcut and could not share one example of
> financial application
> https://github.com/bitcoin/bitcoin/issues/23412#issuecomment-1003496126
>
> TL;DR
>
> https://github.com/bitcoin/bitcoin/pull/23395#issuecomment-956353035
>
> https://github.com/bitcoin/bitcoin/issues/23412#issuecomment-970480769
>
> To be honest, neither I have energy left to highlight the importance of
> these issues nor most of the people look interested in this space to
> address it. This email is a part of my efforts to share things with
> everyone which I even tried with documentation. There is something
> seriously wrong if few people including maintainers acknowledge the
> issues with *notify options but nobody wants to fix it or document it,
> I will leave it for people to form their own opinions about it.
>
> Last but not least I was even asked to not review and comment in
> https://github.com/bitcoin/bitcoin/pull/23395 when I was just
> responding to others.
>
> This will be helpful in my security project which was already shared in
> mailing list to highlight what users expect from developers and future
> of money, review process etc. and what is the ground reality.
>
> Happy New Year
>
> --
> Prayank
>
> A3B1 E430 2298 178F
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
Daniel Edgecumbe [ARCHIVE] /
npub19c…lshne
2023-06-07 23:01:58
in reply to nevent1q…9xfa
Author Public Key
npub19cnllur76rgknvml62gt4uqdtm24kx7rg8ynkyx3rc49dfat58ms5lshnePublished at
2023-06-07 23:01:58Event JSON
{
"id": "a9e4c441c2dcc6f8aad10df10336f12ed9bcc9538dc058118b0c68bc36cf480c",
"pubkey": "2e27fff07ed0d169b37fd290baf00d5ed55b1bc341c93b10d11e2a56a7aba1f7",
"created_at": 1686178918,
"kind": 1,
"tags": [
[
"e",
"f44b3010eed966d4bb7887b28235c3943b9a66b19441436dbc2559f13c19e5a3",
"",
"root"
],
[
"e",
"6c85181c1cab54b09fbd87edbacf2c1210001a5c260595eec5ed546ac14d4f3f",
"",
"reply"
],
[
"p",
"339a4dd213c9ce6fb7143bcbd13868ec03a78b2af67b0465c7cf83164bc01fa1"
]
],
"content": "📅 Original date posted:2022-01-01\n📝 Original message:I've looked at these PR's and they seem, frankly, bizarre.\n\nYou've essentially noticed that if an attacker can run commands on your system, they can run commands on your system.\n\nIf you can convince someone to run arbitrary commands, which is what a desktop shortcut or a command argument _is_ at a fundamental level, you own their system. I fail to see how this has anything to do with Core at all.\n\nDaniel Edgecumbe | esotericnonsense\nemail at esotericnonsense.com | https://esotericnonsense.com\n\nOn Sat, Jan 1, 2022, at 21:03, Prayank via bitcoin-dev wrote:\n\u003e Hello World,\n\u003e\n\u003e What?\n\u003e\n\u003e Remove all *notify options from Bitcoin Core (full node implementation \n\u003e used by 99% nodes)\n\u003e\n\u003e Or one of the below:\n\u003e\n\u003e notifications.dat\n\u003e not use system() in runCommand()\n\u003e Use a new setting in settings.json file, notifypolicy which is 0 by \n\u003e default (restricted) and can be set to 1 (unrestricted)\n\u003e\n\u003e Why?\n\u003e\n\u003e They can help attackers in doing almost anything on machines running \n\u003e Bitcoin Core with some social engineering.\n\u003e\n\u003e How?\n\u003e\n\u003e Everything is explained several times in different issues, PRs etc. to \n\u003e different people including few reviewers who even NACKed a PR that \n\u003e would help in adding such options but with some documentation. I won't \n\u003e comment much about the reviewers but some of them were clueless about \n\u003e issue and how things work.\n\u003e\n\u003e Example: Calling something misleading and ludicrous when you don't even \n\u003e know what works in Windows shortcut and could not share one example of \n\u003e financial application \n\u003e https://github.com/bitcoin/bitcoin/issues/23412#issuecomment-1003496126\n\u003e\n\u003e TL;DR\n\u003e\n\u003e https://github.com/bitcoin/bitcoin/pull/23395#issuecomment-956353035\n\u003e\n\u003e https://github.com/bitcoin/bitcoin/issues/23412#issuecomment-970480769\n\u003e\n\u003e To be honest, neither I have energy left to highlight the importance of \n\u003e these issues nor most of the people look interested in this space to \n\u003e address it. This email is a part of my efforts to share things with \n\u003e everyone which I even tried with documentation. There is something \n\u003e seriously wrong if few people including maintainers acknowledge the \n\u003e issues with *notify options but nobody wants to fix it or document it, \n\u003e I will leave it for people to form their own opinions about it.\n\u003e\n\u003e Last but not least I was even asked to not review and comment in \n\u003e https://github.com/bitcoin/bitcoin/pull/23395 when I was just \n\u003e responding to others. \n\u003e\n\u003e This will be helpful in my security project which was already shared in \n\u003e mailing list to highlight what users expect from developers and future \n\u003e of money, review process etc. and what is the ground reality.\n\u003e\n\u003e Happy New Year\n\u003e\n\u003e -- \n\u003e Prayank\n\u003e\n\u003e A3B1 E430 2298 178F\n\u003e _______________________________________________\n\u003e bitcoin-dev mailing list\n\u003e bitcoin-dev at lists.linuxfoundation.org\n\u003e https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev",
"sig": "e230a27bb59b856a5b2640c9d2dad1e5c6573732c13ef82b602ffdb7c1c1c24973bef5bc9a930139f577d34236f6f566dfcbdc36fcfcfdb41548c8008bcdb1ac"
}