📅 Original date posted:2014-04-28
📝 Original message:There is a discussion about clarifying how BIP70 signs payment requests
here:
https://github.com/bitcoin/bips/pull/41
The issue is what to do with the signature field before signing. The code
Mike and I initially wrote does this:
request.set_signature(string(""));
(sets signature to the empty string)
I think that is a mistake; it should be:
request.clear_signature();
(clears signature field, so it is not serialized at all).
So: if you are implementing, or have implemented, the payment protocol,
please chime in. I'd like to change the spec and the reference
implementation NOW, while BIP70 is still a 'Draft'.
Because this type of "hey, I'm implementing your standard and it doesn't
work the way I think it should" mistake is exactly why BIPs take a while
before being declared 'Final.'
--
--
Gavin Andresen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20140428/6ecc6f09/attachment.html>;
Gavin Andresen [ARCHIVE] /
npub1s4…d44kw
2023-06-07 15:20:30
in reply to nevent1q…agrw
Author Public Key
npub1s4lj77xuzcu7wy04afcr487f0r3za0f8n2775xrpkld2sv639mjqsd44kwPublished at
2023-06-07 15:20:30Event JSON
{
"id": "ac096a7150af2911c448b164e91d3ddb9d3c41e2670ff971dd87f016014fd610",
"pubkey": "857f2f78dc1639e711f5ea703a9fc978e22ebd279abdea1861b7daa833512ee4",
"created_at": 1686151230,
"kind": 1,
"tags": [
[
"e",
"cb6fed619ee0df5a1df25220a81984ff60046186bfb20d856258461f0aad2d8b",
"",
"reply"
],
[
"p",
"a23dbf6c6cc83e14cc3df4e56cc71845f611908084cfe620e83e40c06ccdd3d0"
]
],
"content": "📅 Original date posted:2014-04-28\n📝 Original message:There is a discussion about clarifying how BIP70 signs payment requests\nhere:\n https://github.com/bitcoin/bips/pull/41\n\nThe issue is what to do with the signature field before signing. The code\nMike and I initially wrote does this:\n\n request.set_signature(string(\"\"));\n\n(sets signature to the empty string)\n\nI think that is a mistake; it should be:\n\n request.clear_signature();\n\n(clears signature field, so it is not serialized at all).\n\nSo: if you are implementing, or have implemented, the payment protocol,\nplease chime in. I'd like to change the spec and the reference\nimplementation NOW, while BIP70 is still a 'Draft'.\n\nBecause this type of \"hey, I'm implementing your standard and it doesn't\nwork the way I think it should\" mistake is exactly why BIPs take a while\nbefore being declared 'Final.'\n\n\n-- \n--\nGavin Andresen\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20140428/6ecc6f09/attachment.html\u003e",
"sig": "d0577e9a77c09892dc77886b2314f4c9309a9440f3247ac5e521a373bb3a7e63750a6a849f6f120f8be2d173dacc9fcc0f5ab53996bbd08f6de05766eb27a5b7"
}