📅 Original date posted:2014-06-03
📝 Original message:Hello
What is the issue with the Bitcoin code for 0.9.x with regard to assertions that isn't in 0.8.6 or previous releases?
on April 18th, I offered
https://github.com/bc4-old-c-coder/bitcoin/commit/f0d221e56a12947b67b9c8f43cc5832b665052c8
this commit and code with all side effects removed from the assertions.
Then on the 28th,
https://github.com/bc4-old-c-coder/bitcoin/tree/0.8.6
this code with unit tests working.
And if that isn't enough, I did a video series on building Bitcoind.exe and the static libraries (on MSVC++) all in NDEBUG (release) mode.
See
https://www.youtube.com/playlist?list=PLFnWb0ttBBMLyUuniLp3PJ5Mn4tVUlliZ
Notice that the NDEBUG release mode is featured, and I even run it!
Lastly what does that say about building Bitcoin-qt in release mode? Should one or not??
There is also a video on building an alternate coin-qt.exe in release mode (gcc version) and running it! See
https://www.youtube.com/watch?v=C8GvHpjbAnM
assert() should have no side effects, that is the problem.
See
http://books.google.com/books?id=L5ZbzVnpkXAC&pg=PA72&lpg=PA72&dq=Gotcha+%2328+Side+Effects&source=bl&ots=Rn15TlPmje&sig=tymHqta0aSANwaM2GaXC-1Di_tk&hl=en&sa=X&ei=uVKNU47fCcvTsAT6goHIBA&ved=0CCAQ6AEwAA#v=onepage&q=Gotcha%20%2328%20Side%20Effects&f=false
a
great book, BTW. Everyone who thinks they know what they are doing
when they write C++ should read this book! They will realize that they
don't know Jack
Why weren't these and all the other examples of amateur, i.e., non-professional, software fixed way back in version 0.3.0 in 2010, before any more releases were done? And why were these and other sub-standard coding practices continued and expanded in later releases, right up until the present?
Ron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20140603/194feac4/attachment.html>;
Ron [ARCHIVE] /
npub152…4jy9y
2023-06-07 15:22:15
in reply to nevent1q…ruhs
Author Public Key
npub152jz30tnjah5kl43tdxjauapmtfhqmns7y4dc44jjg3l3pf6rhkqa4jy9yPublished at
2023-06-07 15:22:15Event JSON
{
"id": "a38835b4c9fffb3e498b13a840a624194607ffee909348054717133d52c2f9d3",
"pubkey": "a2a428bd73976f4b7eb15b4d2ef3a1dad3706e70f12adc56b29223f8853a1dec",
"created_at": 1686151335,
"kind": 1,
"tags": [
[
"e",
"e8b77add504144678225b9ea55ec19a8c038095fd045917174210773a0ed69db",
"",
"reply"
],
[
"p",
"a23dbf6c6cc83e14cc3df4e56cc71845f611908084cfe620e83e40c06ccdd3d0"
]
],
"content": "📅 Original date posted:2014-06-03\n📝 Original message:Hello\n\nWhat is the issue with the Bitcoin code for 0.9.x with regard to assertions that isn't in 0.8.6 or previous releases?\n\non April 18th, I offered \n\nhttps://github.com/bc4-old-c-coder/bitcoin/commit/f0d221e56a12947b67b9c8f43cc5832b665052c8 \n\nthis commit and code with all side effects removed from the assertions.\n\n\nThen on the 28th,\n\nhttps://github.com/bc4-old-c-coder/bitcoin/tree/0.8.6 \n\nthis code with unit tests working.\n\nAnd if that isn't enough, I did a video series on building Bitcoind.exe and the static libraries (on MSVC++) all in NDEBUG (release) mode.\n\nSee\nhttps://www.youtube.com/playlist?list=PLFnWb0ttBBMLyUuniLp3PJ5Mn4tVUlliZ \nNotice that the NDEBUG release mode is featured, and I even run it!\n\nLastly what does that say about building Bitcoin-qt in release mode? Should one or not??\n\nThere is also a video on building an alternate coin-qt.exe in release mode (gcc version) and running it! See \nhttps://www.youtube.com/watch?v=C8GvHpjbAnM \n\n\n \n\n\nassert() should have no side effects, that is the problem.\n\nSee\nhttp://books.google.com/books?id=L5ZbzVnpkXAC\u0026pg=PA72\u0026lpg=PA72\u0026dq=Gotcha+%2328+Side+Effects\u0026source=bl\u0026ots=Rn15TlPmje\u0026sig=tymHqta0aSANwaM2GaXC-1Di_tk\u0026hl=en\u0026sa=X\u0026ei=uVKNU47fCcvTsAT6goHIBA\u0026ved=0CCAQ6AEwAA#v=onepage\u0026q=Gotcha%20%2328%20Side%20Effects\u0026f=false\n\na\n great book, BTW. Everyone who thinks they know what they are doing \nwhen they write C++ should read this book! They will realize that they \ndon't know Jack \n\nWhy weren't these and all the other examples of amateur, i.e., non-professional, software fixed way back in version 0.3.0 in 2010, before any more releases were done? And why were these and other sub-standard coding practices continued and expanded in later releases, right up until the present? \n\nRon\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20140603/194feac4/attachment.html\u003e",
"sig": "ddf325ec053102fa1f1c1220cfb75214415be94ab753d36d039da967cacab7e65bfbdc885cbd1b0e9aa981983787cbf98d6fee22b646885a67ef9a3b68d8105e"
}