📅 Original date posted:2013-10-03
📝 Original message:I only bring this up here since I can't raise https://bitcointalk.org? Perhaps it runs on the silk road servers:)
Upon looking at the 0.8.5 & earlier code for CDB:Rewrite(), in the files db.h and db.cpp, you will notice that in db.h it is declared bool static, but in db.cpp it isn't. Is this a problem? Or a feature? Or nothing at all?
Furthermore, it is called only in wallet.cpp -->CWallet::EncryptWallet() but its return value is ignored? Again, intentional or a bug or a feature or a ...?
Now CWallet::EncryptWallet() is called by AskPassphraseDialog::accept() and WalletModel::setWalletEncrypted()and they seem very interested in what CWallet::EncryptWallet() returns. Could this be involved in some old issue with wallet encryption on bitcoin-qt 0.8.1?
There seems to be plenty of this kind of "suspicious" code to ferret about in, with one's IDE during quiet moments. Amusing is to follow return 0 and return 1 to try and infer their meaning, their intent?
Ron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20131002/ad22c996/attachment.html>;
Ron [ARCHIVE] /
npub152…4jy9y
2023-06-07 15:07:13
in reply to nevent1q…ea3p
Author Public Key
npub152jz30tnjah5kl43tdxjauapmtfhqmns7y4dc44jjg3l3pf6rhkqa4jy9yPublished at
2023-06-07 15:07:13Event JSON
{
"id": "a8b2bb5b52d19f441e97e46104d6e201964236ae724f89b34bdb3d25870ca778",
"pubkey": "a2a428bd73976f4b7eb15b4d2ef3a1dad3706e70f12adc56b29223f8853a1dec",
"created_at": 1686150433,
"kind": 1,
"tags": [
[
"e",
"71a601ad211d562b159541db8edce93b180790a1fcc7ac7faa3588a8e19569ad",
"",
"reply"
],
[
"p",
"a23dbf6c6cc83e14cc3df4e56cc71845f611908084cfe620e83e40c06ccdd3d0"
]
],
"content": "📅 Original date posted:2013-10-03\n📝 Original message:I only bring this up here since I can't raise https://bitcointalk.org? Perhaps it runs on the silk road servers:)\n\nUpon looking at the 0.8.5 \u0026 earlier code for CDB:Rewrite(), in the files db.h and db.cpp, you will notice that in db.h it is declared bool static, but in db.cpp it isn't. Is this a problem? Or a feature? Or nothing at all?\n\n\nFurthermore, it is called only in wallet.cpp --\u003eCWallet::EncryptWallet() but its return value is ignored? Again, intentional or a bug or a feature or a ...?\nNow CWallet::EncryptWallet() is called by AskPassphraseDialog::accept() and WalletModel::setWalletEncrypted()and they seem very interested in what CWallet::EncryptWallet() returns. Could this be involved in some old issue with wallet encryption on bitcoin-qt 0.8.1?\n\nThere seems to be plenty of this kind of \"suspicious\" code to ferret about in, with one's IDE during quiet moments. Amusing is to follow return 0 and return 1 to try and infer their meaning, their intent?\n\n\nRon\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20131002/ad22c996/attachment.html\u003e",
"sig": "1d8ea76f31fb3b8aef8b8267f70fa636eee3b7d4601424b33c135d32a650d6282586838dd1ef9e511b9562c0a7475e2d85f57add618a7879e3f5cb778477be45"
}