Gavin Andresen [ARCHIVE] on Nostr: š
Original date posted:2011-09-15 šļø Summary of this message: Gavin Andresen ...
š
Original date posted:2011-09-15
šļø Summary of this message: Gavin Andresen plans to simplify the banning system for nodes accumulating more than -banscore misbehavior points and add a bad signature banning offense.
š Original message:Thanks Mike, that's exactly the kind of detailed review I was looking
for. I think you're right an all points.
I'll simplify: I'll add a -banscore option (default 100), and if a
node accumulates more than -banscore misbehavior points it'll get
dropped and banned for -bantime (default 60*60*24) seconds.
I'll make bad signatures a banning offense, and I'll remove the
number-of-sigops and non-standard-transaction penalties.
I used a mutable field with const setter to avoid modifying a bunch of
methods to take non-const blocks/transactions instead of const; I
think it is appropriate because a block/transaction's DoS score is
really meta-data and not part of it's state.
I'll make GetTime() unit-test friendly as you suggest.
--
--
Gavin Andresen
Published at
2023-06-07 02:26:42Event JSON
{
"id": "f27df72305fc3492cb2d05017f20adc6aadcb69d904a82f6da44366c03fb2d71",
"pubkey": "857f2f78dc1639e711f5ea703a9fc978e22ebd279abdea1861b7daa833512ee4",
"created_at": 1686104802,
"kind": 1,
"tags": [
[
"e",
"e29ff4d93432370a19179a042d2501986d93a8b4cdbf351edfd1916f772bb3bb",
"",
"root"
],
[
"e",
"49a7df9e32a7e926a4be0e953ab38d96479be66d9247b81dd7568488403fb038",
"",
"reply"
],
[
"p",
"f2c95df3766562e3b96b79a0254881c59e8639f23987846961cf55412a77f6f2"
]
],
"content": "š
Original date posted:2011-09-15\nšļø Summary of this message: Gavin Andresen plans to simplify the banning system for nodes accumulating more than -banscore misbehavior points and add a bad signature banning offense.\nš Original message:Thanks Mike, that's exactly the kind of detailed review I was looking\nfor. I think you're right an all points.\n\nI'll simplify: I'll add a -banscore option (default 100), and if a\nnode accumulates more than -banscore misbehavior points it'll get\ndropped and banned for -bantime (default 60*60*24) seconds.\n\nI'll make bad signatures a banning offense, and I'll remove the\nnumber-of-sigops and non-standard-transaction penalties.\n\nI used a mutable field with const setter to avoid modifying a bunch of\nmethods to take non-const blocks/transactions instead of const; I\nthink it is appropriate because a block/transaction's DoS score is\nreally meta-data and not part of it's state.\n\nI'll make GetTime() unit-test friendly as you suggest.\n\n-- \n--\nGavin Andresen",
"sig": "f3cdd0cfb019f91dabe9dff2b7f05de0823bd36127f65cb5fa30bfe6ee6310208856cc26c5ed351e88aa6496997f1b71ea7b8212bcf09bad5bbaad9266ff915e"
}