A new PR Review Club episode!
We reviewed PR #27374, exploring the exclusion of 'netgroup' diversity checking for tor/i2p/cjdns networks.
This PR allows the node to bypass netgroup diversity checks for outbound connections in privacy networks as IP address diversity isn't applicable to them.
In this episode, PR author @spherostrat helped us explore:
- P2P Networks
- Netgroup Basics
- Outbound Peer-Selection Logic
- Eclipse Attacks
Her engaging whiteboard presentation brought these concepts to life!
Watch it now on YouTube: https://youtu.be/IbU3fAkumJk
PR summary and discussed questions: https://github.com/Bitshala/Bitcoin-PR-Review-Club/discussions/24
#Bitcoin #BitcoinCore #PRreviews
bitshala
npub1m4…pu22l
2023-06-19 15:58:23
Author Public Key
npub1m495fdq2e8jleptdq6ruzpmz0esjttln2rjx7dxj9w4zvxs48y3q5pu22lPublished at
2023-06-19 15:58:23Event JSON
{
"id": "f5fa18ccbf943c2c035cbe327a134a7c90afd742147a198f21b9e3514565408a",
"pubkey": "dd4b44b40ac9e5fc856d0687c107627e6125aff350e46f34d22baa261a153922",
"created_at": 1687190303,
"kind": 1,
"tags": [
[
"t",
"27374"
],
[
"t",
"Bitcoin"
],
[
"t",
"BitcoinCore"
],
[
"t",
"PRreviews"
]
],
"content": "A new PR Review Club episode! \n\nWe reviewed PR #27374, exploring the exclusion of 'netgroup' diversity checking for tor/i2p/cjdns networks.\n\nThis PR allows the node to bypass netgroup diversity checks for outbound connections in privacy networks as IP address diversity isn't applicable to them.\n\nIn this episode, PR author @spherostrat helped us explore:\n- P2P Networks\n- Netgroup Basics\n- Outbound Peer-Selection Logic\n- Eclipse Attacks\n\nHer engaging whiteboard presentation brought these concepts to life!\n\nWatch it now on YouTube: https://youtu.be/IbU3fAkumJk\n\nPR summary and discussed questions: https://github.com/Bitshala/Bitcoin-PR-Review-Club/discussions/24\n\n#Bitcoin #BitcoinCore #PRreviews",
"sig": "c3e7a071cfff1e68a4b03c28143180245003c4de77d06b2f602e304e3aafb48a39ef6cccb56a9493d78992016e9a8d650b949fd0abb2d8b522c6f4bd83634fa5"
}