📅 Original date posted:2015-01-22
📝 Original message:On Wed, Jan 21, 2015 at 11:18 PM, Matt Whitlock <bip at mattwhitlock.name> wrote:
> To be more in the C++ spirit, I would suggest changing the (const std::vector<unsigned char> &sig, size_t &off) parameters to (std::vector<unsigned char>::const_iterator &itr, std::vector<unsigned char>::const_iterator end).
I agree that is more in the spirit of C++, but part of the motivation
for including C++ code that it mostly matches the exact code that has
been used in the past two major Bitcoin Core releases (to interpret
signatures as standard).
--
Pieter
Pieter Wuille [ARCHIVE] /
npub1tj…jtl6r
2023-06-07 15:28:56
in reply to nevent1q…ld7d
Author Public Key
npub1tjephawh7fdf6358jufuh5eyxwauzrjqa7qn50pglee4tayc2ntqcjtl6rPublished at
2023-06-07 15:28:56Event JSON
{
"id": "f9fa4ea721d81b763be5237280557b71a49431015e733cb593a76a92dd37077b",
"pubkey": "5cb21bf5d7f25a9d46879713cbd32433bbc10e40ef813a3c28fe7355f49854d6",
"created_at": 1686151736,
"kind": 1,
"tags": [
[
"e",
"43498997aaf69cc28c108f60f2a0a9a1eeab544cf4e7f9ece35a133ac15cb4c1",
"",
"root"
],
[
"e",
"105a592238feaa5f03174d096cb30e7aa717909bb4cb7426a241bcf7fe4760fc",
"",
"reply"
],
[
"p",
"f00d0858b09287e941ccbc491567cc70bdbc62d714628b167c1b76e7fef04d91"
]
],
"content": "📅 Original date posted:2015-01-22\n📝 Original message:On Wed, Jan 21, 2015 at 11:18 PM, Matt Whitlock \u003cbip at mattwhitlock.name\u003e wrote:\n\u003e To be more in the C++ spirit, I would suggest changing the (const std::vector\u003cunsigned char\u003e \u0026sig, size_t \u0026off) parameters to (std::vector\u003cunsigned char\u003e::const_iterator \u0026itr, std::vector\u003cunsigned char\u003e::const_iterator end).\n\nI agree that is more in the spirit of C++, but part of the motivation\nfor including C++ code that it mostly matches the exact code that has\nbeen used in the past two major Bitcoin Core releases (to interpret\nsignatures as standard).\n\n-- \nPieter",
"sig": "c4e1dc4c19fcf8f753b6651676fb8a5ec7d0017898e73b5c7a9747cc0c277cd1de8b44a323388a8e5818f2d39ad02b5957fc48f6564a1530094e5c875946a3d0"
}