Thanks for the code, just doing some quick code review here.
I think the first issue I spotted is the assigning a stream send$ to itself `socket.send$ = send$.pipe` try to think some other way to do that, it's very easy to compose multiple observables that derives from the same source in a functional style.
I would do something like on socket.ts
```ts
this.socket = webSocketSubject('...')
this.events$ = socket.pipe(filter(msg => msg[0] === 'event'))
this.auths$ = socket.pipe(filter(msg => msg[0] === 'AUTH'))
this.authsJoin$ = auths$.pipe(filter(msg => msg[1].kind === 28934))
this.oks$ = socket.pipe(filter(msg => msg[0] === 'OK'))
```
I would also remove the `authState.subscribe` for something like `return authState.pipe(tap(() => {}))`, but AuthState is a subject with a bunch of subscriptions inside there... hmmm, that's a bit bad, by looking at the commit history you basically kinda ported a event emitter system to rxjs right? you gonna have to embrace some heavy changes to see the gains of rxjs.
Try to think this way, let's say you have a single nostr subscription to a single relay, this subscription has all sorts of complex policies attached to the main stream, the main stream is also connected with other subscription stream like getting each user for each note in the main stream with also their own set of policies, then you decided to call unsubscribe() from the main stream, then the entire pipeline is unsubscribed and garbage collected, nothing left, with your current approach I am not seeing this happening, you might ended up with some parts of stream still listening for changes, unless you complete/unsubscribe the streams manually in multiple places which is a lot of work, which is something you have to do with event emitters.
I also did these exact mistakes a year ago, so I really don't judge you 😅
this angular tutorial describes really well the issue.
https://www.youtube.com/watch?v=bxslNFZvOvQ
cesardias / Cesar Dias
npub1ce…kt37c
2025-03-27 17:36:08
in reply to nevent1q…ucnj
Author Public Key
npub1cesrkrcuelkxyhvupzm48e8hwn4005w0ya5jyvf9kh75mfegqx0q4kt37cPublished at
2025-03-27 17:36:08Event JSON
{
"id": "f8d733bd996ed867b2a997df88910320301f7c627f1cd0f6048db23a1194e2dc",
"pubkey": "c6603b0f1ccfec625d9c08b753e4f774eaf7d1cf2769223125b5fd4da728019e",
"created_at": 1743096968,
"kind": 1,
"tags": [
[
"e",
"7232af889e79b07bc8dab1307acc24766bd869f9a9be3ff86f8239be532ef2f9",
"wss://hbr.coracle.social",
"root",
"97c70a44366a6535c145b333f973ea86dfdc2d7a99da618c40c64705ad98e322"
],
[
"e",
"78e69a3443a73dcf03e4a3db077f409c8793aaf229ae98aba2c67c966b761c95",
"wss://nos.lol",
"reply",
"97c70a44366a6535c145b333f973ea86dfdc2d7a99da618c40c64705ad98e322"
],
[
"p",
"97c70a44366a6535c145b333f973ea86dfdc2d7a99da618c40c64705ad98e322",
"wss://nos.lol"
],
[
"client",
"nosotros",
"31990:c6603b0f1ccfec625d9c08b753e4f774eaf7d1cf2769223125b5fd4da728019e:1728437063755"
]
],
"content": "Thanks for the code, just doing some quick code review here.\n\nI think the first issue I spotted is the assigning a stream send$ to itself `socket.send$ = send$.pipe` try to think some other way to do that, it's very easy to compose multiple observables that derives from the same source in a functional style.\n\nI would do something like on socket.ts\n\n```ts\nthis.socket = webSocketSubject('...')\nthis.events$ = socket.pipe(filter(msg =\u003e msg[0] === 'event'))\nthis.auths$ = socket.pipe(filter(msg =\u003e msg[0] === 'AUTH'))\nthis.authsJoin$ = auths$.pipe(filter(msg =\u003e msg[1].kind === 28934))\nthis.oks$ = socket.pipe(filter(msg =\u003e msg[0] === 'OK'))\n```\n\nI would also remove the `authState.subscribe` for something like `return authState.pipe(tap(() =\u003e {}))`, but AuthState is a subject with a bunch of subscriptions inside there... hmmm, that's a bit bad, by looking at the commit history you basically kinda ported a event emitter system to rxjs right? you gonna have to embrace some heavy changes to see the gains of rxjs.\n\nTry to think this way, let's say you have a single nostr subscription to a single relay, this subscription has all sorts of complex policies attached to the main stream, the main stream is also connected with other subscription stream like getting each user for each note in the main stream with also their own set of policies, then you decided to call unsubscribe() from the main stream, then the entire pipeline is unsubscribed and garbage collected, nothing left, with your current approach I am not seeing this happening, you might ended up with some parts of stream still listening for changes, unless you complete/unsubscribe the streams manually in multiple places which is a lot of work, which is something you have to do with event emitters.\n\nI also did these exact mistakes a year ago, so I really don't judge you 😅\n\nthis angular tutorial describes really well the issue.\n\nhttps://www.youtube.com/watch?v=bxslNFZvOvQ",
"sig": "d38cdab26dd233c6d5018d13f1cd1cfd8d9931f1e2cd2dc0ca84ed7fd2fcebf284173ee420e7e50fc858f1ae2a80a90bd8f3e8dbf7e446892ff471b339ab2ef8"
}